Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added “Abort” In Case of Loading Errors #27

Closed
EliteAsian123 opened this issue Mar 23, 2023 · 0 comments
Closed

Added “Abort” In Case of Loading Errors #27

EliteAsian123 opened this issue Mar 23, 2023 · 0 comments
Labels
Enhancement New feature or request

Comments

@EliteAsian123
Copy link
Member

Prevent soft-locks.

@EliteAsian123 EliteAsian123 added the Enhancement New feature or request label Mar 23, 2023
Purplo-cf pushed a commit to Purplo-cf/YARG that referenced this issue May 14, 2024
…-Official#27)

* Rework chart event constructor parameters
- Reorganize note parameters to better follow class hierarchy
- Remove previousNote parameter, it's not really that useful
- Remove text event length parameters

* Reorganize note flags
- Move instrument-specific note flags to their respective types
- Change values to use `1 << x` instead of raw values
- Move IsChord to Note, and base it off of the child note count instead of a flag
- Add missing properties for flags

* Tidy up chart event fields and properties
- Reordered by modifiers: private first, public last
- Aligned everything in columns

* Fix child notes list not getting created

* Add guitar/drums note value definitions and vocals harmony part value
Removed the drums cymbal flag, it's now part of the note value

* Add note type values to guitar/drum notes

* Add SP activator flag to drum notes

* Add Pro Guitar note

* (Re-)Add convenience properties for note types

* Allow publically setting note type values

* Simplify guitar/Pro guitar IsSustain property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant