Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ardwiino support #29

Closed
sanjay900 opened this issue Mar 23, 2023 · 7 comments
Closed

Ardwiino support #29

sanjay900 opened this issue Mar 23, 2023 · 7 comments
Labels
Enhancement New feature or request

Comments

@sanjay900
Copy link
Contributor

sanjay900 commented Mar 23, 2023

This project looks dope!

If i were to submit a PR for adding in reactive LED support for my new firmware, would that sorta thing be merged in?
The plan is to use HID output reports for enabling and disabling LEDs depending on game state for HID, and rumble commands for xinput.

It would be cool to have something with proper support for this baked in, as then I have a nice way to test all these new features before I investigate modding other games.

Happy to send test firmwares your way or something if you do happen to have a arduino / pico modded guitar and want to test things yourself once it gets to that point, assuming the new firmware isn't released by the time i get around to this.

@EliteAsian123
Copy link
Member

Hi! I'm actually aware of your work and am very impressed with it! I was talking to the creator of Polybar, and he should be sending one my way once he gets some parts.

I'm 100% towards adding proper LED support, and was actually thinking of it already. If you don't get around to making a pull request, I was probably gonna do it myself anyway once I get my hands on the Polybar. However, if you could do it, I'd be very thankful!

Thanks!

@EliteAsian123 EliteAsian123 added the Enhancement New feature or request label Mar 23, 2023
@sanjay900
Copy link
Contributor Author

Are you planning on stagekit support as well?

@EliteAsian123
Copy link
Member

I actually did not even know that existed! If I ever get my hands on one, I'll definitaly add support, but I'm sure on how easy they are to get.

@sanjay900
Copy link
Contributor Author

I have ways to emulate them now as well in the next firmware release

@sanjay900
Copy link
Contributor Author

I'm just glad you aren't using rewired because it complicates the hell out of LEDs for anything that isn't xinput

@sanjay900
Copy link
Contributor Author

Well, this one was sorted

@TheNathannator
Copy link
Collaborator

Been quite the journey lol, glad to have everything supported!

Purplo-cf pushed a commit to Purplo-cf/YARG that referenced this issue May 14, 2024
…l#29)

* Remove MaxDifficulty field from InstrumentTrack
Not really necessary on second thought, can just check if the difficulty exists lol

* Default-initialize instrument parts and make them publically settable

* Uncomment Pro Guitar tracks, and change Harmonies to just a single track
VocalNote has a HarmonyPart value now, so we don't need separate tracks for each part

* Add ISongLoader interface to abstract song loading

* Uncomment 6-fret instruments/game mode

* Implement Moonscraper loader skeleton

* Implement 5/6-fret guitar loading

* Implement Pro guitar loading

* Implement drums loading

* Add dedicated vocals track types
Vocals doesn't have distinct difficulty tracks
Vocals phrases and parts should also be tracked directly

* Turn Note into a recursive generic type
Avoids type testing and allows vocal pitch bends to be stored more sanely

* Rework vocals pitch-over-time storage to use child notes

* Rework some things in VocalNote, and add doc comments

* Implement vocals note loader

* Quick Moonscraper bugfix I found when testing

* Remove Moonscraper using directive from GuitarNote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants