Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace phantomjs #37

Open
XhmikosR opened this issue Aug 5, 2017 · 7 comments
Open

Replace phantomjs #37

XhmikosR opened this issue Aug 5, 2017 · 7 comments

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Aug 5, 2017

Since phantom-js is no longer maintained, perhaps jsdom could be used?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Aug 5, 2017

I should have checked the source first. Since jsdom is there, I'd suggest that is completely removed; too much overhead and jsdom seems to work fine.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Aug 5, 2017

Hmm, now I remember... With browser: false thus using jsdom, testing is super slow at least on my Windows system.

@axten
Copy link

axten commented Oct 24, 2017

@yargalot i think phantom js should be removed completely because its bloating the node_modules folder by ~60MB.

@gamebox
Copy link

gamebox commented Feb 9, 2018

We could also remove PhantomJS and use Puppeteer along with Chrome Headless. I could help with a PR here is that sounds like a good solution.

@yargalot
Copy link
Owner

yargalot commented Feb 9, 2018

Yeh makes sense to replace phantom with puppeteer. Happy to take that as a pull request

@gamebox
Copy link

gamebox commented Feb 9, 2018

Awesome, I'll work on that and submit when I get a chance

@axten
Copy link

axten commented Jun 7, 2018

any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants