-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace phantomjs #37
Comments
I should have checked the source first. Since jsdom is there, I'd suggest that is completely removed; too much overhead and jsdom seems to work fine. |
Hmm, now I remember... With |
@yargalot i think phantom js should be removed completely because its bloating the node_modules folder by ~60MB. |
We could also remove PhantomJS and use Puppeteer along with Chrome Headless. I could help with a PR here is that sounds like a good solution. |
Yeh makes sense to replace phantom with puppeteer. Happy to take that as a pull request |
Awesome, I'll work on that and submit when I get a chance |
any updates here? |
Since phantom-js is no longer maintained, perhaps jsdom could be used?
The text was updated successfully, but these errors were encountered: