Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: explicitly set noEmit: false in the build script #6266

Merged
merged 3 commits into from
May 2, 2024

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 2, 2024

What's the problem this PR addresses?

#6133 (cc @clemyan) enabled noEmit by default which caused yarn pack to not get any build output.

Fixes #6265

How did you fix it?

Explicitly set noEmit: false in the build script.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

arcanis
arcanis previously approved these changes May 2, 2024
@merceyz merceyz changed the title build: enable TypeScript emit build: explicitly set noEmit: false in the build script May 2, 2024
@arcanis arcanis merged commit 33a8c80 into master May 2, 2024
20 of 24 checks passed
@arcanis arcanis deleted the merceyz/build/fix-builds branch May 2, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to install sdk for vscode
2 participants