-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate docs to Docusaurus v3 #6133
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out, the package info page uses some of docusaurus's internal components and is broken after the migration. Marking the PR as draft for now. |
clemyan
force-pushed
the
docusaurus-v3
branch
2 times, most recently
from
February 22, 2024 14:29
b1c020b
to
0ddac25
Compare
Avoid patching the MDX loader using resolve alias as in https://github.com/arcanis/mael.dev-docs/blob/f618643d59d76f19127e275ecfaf8a781be0c941/docusaurus.config.js#L86-L87
3 tasks
arcanis
pushed a commit
that referenced
this pull request
May 2, 2024
**What's the problem this PR addresses?** #6133 (cc @clemyan) enabled `noEmit` by default which caused `yarn pack` to not get any build output. Fixes #6265 **How did you fix it?** Explicitly set `noEmit: false` in the build script. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
3 tasks
arcanis
pushed a commit
that referenced
this pull request
Jun 20, 2024
## What's the problem this PR addresses? <!-- Describe the rationale of your PR. --> <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) --> PR #6133 renamed the contributing file. This PR adjusts sources to changes. ## How did you fix it? <!-- A detailed description of your implementation. --> ... ## Checklist <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [ ] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [x] I will check that all automated PR checks pass before the PR gets reviewed. Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The docs website is on Docsaurus v2 which is not the latest major version
Closes #5918
Closes #6153
How did you fix it?
Migrate to Docsaurus v3.
There are other improvements to the build process and website I'd like to make, but I have left them out and kept most of the logic intact since the migration is quite a large undertaking already.
Checklist