-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't auto clean .yml files. #2276
Comments
any update ? |
still get a problem when exec yarn clean, such as .svgo.yml problem reproduce everytime. yarn version: v0.23.4 |
+1 |
This issue just bit me as well. I'm by no means an expert in this field, but why do you even bother to selectively delete/keep files? On
... or similar. |
I'm actually curious what the use case is for even running I can only venture to guess that the intent was to remove files that probably weren't needed for a production deployment to run, saving some HD space, but it doesn't seem like the I would think a lot of issues could be avoided by just removing this command, or do what NPM5 did with |
Just fell into the same trap. Why exactly is there a function that as a result will permanently destroy your build until you deactivate it? |
+1 to this. PR's welcome everyone :D |
…4724) **Summary** Remove entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`. Instead, include configuration files from common CI and build tools. - Travis CI - CircleCI - AppVeyor - Codeship - Wercker Fixes #4281, fixes #2276. **Test plan** ```shell $ yarn autoclean --init yarn autoclean v1.2.1 [1/1] Creating ".yarnclean"... info Created ".yarnclean". Please review the contents of this file then run "yarn autoclean --force" to perform a clean. ✨ Done in 0.15s. $ grep yml .yarnclean appveyor.yml circle.yml codeship-services.yml codeship-steps.yml wercker.yml .travis.yml ```
…arnpkg#4724) **Summary** Remove entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`. Instead, include configuration files from common CI and build tools. - Travis CI - CircleCI - AppVeyor - Codeship - Wercker Fixes yarnpkg#4281, fixes yarnpkg#2276. **Test plan** ```shell $ yarn autoclean --init yarn autoclean v1.2.1 [1/1] Creating ".yarnclean"... info Created ".yarnclean". Please review the contents of this file then run "yarn autoclean --force" to perform a clean. ✨ Done in 0.15s. $ grep yml .yarnclean appveyor.yml circle.yml codeship-services.yml codeship-steps.yml wercker.yml .travis.yml ```
Do you want to request a feature or report a bug?
Bug.
What is the current behavior?
Related to #1051. Right now
yarn clean
produces a clean file that removes.yml
files.What is the expected behavior?
It's too aggressive to auto delete config files. You wouldn't auto delete
.toml
or.json
files, so also shouldn't auto delete.yml
files.It would be more appropriate to remove specific well known configs, like
circle.yml
etc.Please mention your node.js, yarn and operating system version.
The text was updated successfully, but these errors were encountered: