[SUGGESTION] Make *.yml optional in initial .yarnclean #4281
Comments
|
I'm +1 for this. @arcanis? |
|
Agree. I'd even be in favor to replace it with an explicit |
|
@hron would you like to submit a PR? It should be easy ;) |
|
@BYK sorry, I'm not too familiar with NodeJS development, I use yarn to handle frontend stuffs. Even worse, I'm not too skilled in JS. I'm really sorry guys, I'd like to help, but I can't. I've no idea where you do these things and I can't figure it out from the source tree at first view. |
lzhang
added a commit
to lzhang/yarn
that referenced
this issue
Oct 17, 2017
Address yarnpkg#4281 by removing entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`.
BYK
pushed a commit
that referenced
this issue
Oct 17, 2017
…4724) **Summary** Remove entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`. Instead, include configuration files from common CI and build tools. - Travis CI - CircleCI - AppVeyor - Codeship - Wercker Fixes #4281, fixes #2276. **Test plan** ```shell $ yarn autoclean --init yarn autoclean v1.2.1 [1/1] Creating ".yarnclean"... info Created ".yarnclean". Please review the contents of this file then run "yarn autoclean --force" to perform a clean. ✨ Done in 0.15s. $ grep yml .yarnclean appveyor.yml circle.yml codeship-services.yml codeship-steps.yml wercker.yml .travis.yml ```
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this issue
Oct 27, 2017
…arnpkg#4724) **Summary** Remove entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`. Instead, include configuration files from common CI and build tools. - Travis CI - CircleCI - AppVeyor - Codeship - Wercker Fixes yarnpkg#4281, fixes yarnpkg#2276. **Test plan** ```shell $ yarn autoclean --init yarn autoclean v1.2.1 [1/1] Creating ".yarnclean"... info Created ".yarnclean". Please review the contents of this file then run "yarn autoclean --force" to perform a clean. ✨ Done in 0.15s. $ grep yml .yarnclean appveyor.yml circle.yml codeship-services.yml codeship-steps.yml wercker.yml .travis.yml ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Do you want to request a feature or report a bug?
It's just a suggestion
What is the current behavior?
The automagically created
.yarncleanincludes*.ymlwhich can cause problems on packages likeelectron-builderthat stores messages or other stuffs in YAML (see electron-userland/electron-builder#1487)If the current behavior is a bug, please provide the steps to reproduce.
What is the expected behavior?
Make *.yml commented out but still included in newly created .yarnclean files.
Please mention your node.js, yarn and operating system version.
N/A
The text was updated successfully, but these errors were encountered: