fix(autoclean): Include only common CI configs in default .yarnclean #4724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address yarnpkg#4281 by removing entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`.
|
This change will increase the build size from 9.94 MB to 9.94 MB, an increase of 215 bytes (0%)
|
|
Also resolves #2276. |
BYK
approved these changes
Oct 17, 2017
|
Very well thought out patch. Thanks a lot! |
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…arnpkg#4724) **Summary** Remove entries to clean `*.yml` and `.*.yml` from the default filter list in `.yarnclean`. Instead, include configuration files from common CI and build tools. - Travis CI - CircleCI - AppVeyor - Codeship - Wercker Fixes yarnpkg#4281, fixes yarnpkg#2276. **Test plan** ```shell $ yarn autoclean --init yarn autoclean v1.2.1 [1/1] Creating ".yarnclean"... info Created ".yarnclean". Please review the contents of this file then run "yarn autoclean --force" to perform a clean. ✨ Done in 0.15s. $ grep yml .yarnclean appveyor.yml circle.yml codeship-services.yml codeship-steps.yml wercker.yml .travis.yml ```
|
If you reach here looking at one of the related bugs, starting Nov 1, 2017 this fix is available in yarn version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove entries to clean
*.ymland.*.ymlfrom the default filter list in.yarnclean. Instead, include configuration files from common CI and build tools.Fixes #4281, fixes #2276.
Test plan