-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private github repository returns invalid package version #6195
Comments
I think the "version" it is complaining about is from |
@rally25rs looks like that is indeed what it is referring to. For tag For tag
Why does it say that EDIT: So it looks like they don't need to be identical, but they have to be semver? I tried
and it installed version |
Ah, so it looks like official semver doesn't consider According to npm's semver package:
This is what is leading to the message
|
I think the following improvements could be made to yarn in that case.
As a side note this appears to be related to npm/node-semver#232 |
@vinnymac You are a god or at least a lower deity for discovering that package.json requirement for version! THANK YOU |
I'm using yarn v1.22.4.
But if I then run instead |
Fixed this issue by adding |
I see this issue with valid semver and the project's |
@yaizudamashii I do not get an error when using that github reference as a dependency.
|
Closing this issue as the original cause was found to be a missing |
@ltfschoen please, were you able to resolve your use case? In my case, |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
I have tested this behavior using the following versions of yarn:
I receive the following output when trying to install my dependency tagged as
0.0.1
If I try to use other tags, such as one with characters in them or non-semver compliant tags I get a slightly different message.
Trying to regenerate my
yarn.lock
file results in the same message above.If I attempt to see if yarn can list my dependency using version
1.9.2
I see thisThe lockfile shows my dependency as it was generated by
1.3.2
as the followingIf the current behavior is a bug, please provide the steps to reproduce.
This is a private repository, otherwise I would share it with you. If you have access to private repositories you can try to create tags identical to the ones above, and see if it works the same for you. Maybe even adding the dependencies I do will help. If you have recommendations for what I can do to more easily create a reproduction, I am open to trying anything.
What is the expected behavior?
I have tested that the expected behavior functions properly using the following versions of yarn:
On these versions of yarn, it finds the package version and installs the dependencies as I would expect. The dependency is added to my
yarn.lock
file and I currently am using1.3.2
until I find another version that suites my needs.Please mention your node.js, yarn and operating system version.
System Details
NodeJS - v8.11.1 (I've tested v7 and v6 as well)
Yarn - v1.9.2
macOS - 10.13.6
I have been able to reproduce this on more than one machine, I attempted 5 different machines, all were running 10.13 variants.
If this is a duplicate issue, I apologize as I tried to search through and see if anyone had anything similar posted, but could not find one.
The text was updated successfully, but these errors were encountered: