Show error message in stdout. #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvhoven
commented
Oct 27, 2016
| @@ -315,7 +315,8 @@ function onUnexpectedError(err: Error) { | |||
| const errorLoc = path.join(config.cwd, 'yarn-error.log'); | |||
| fs.writeFileSync(errorLoc, log.join('\n\n') + '\n'); | |||
|
|
|||
| reporter.error(reporter.lang('unexpectedError', errorLoc)); | |||
| reporter.error(reporter.lang('unexpectedError', err.stack)); | |||
There was a problem hiding this comment.
Should I concat err.stack? It only shows the first part of the stack e.g: Error: EACCES: permission denied, open '/home/jeffrey/Documents/Projects/yarn-testing/package.json'\n at Error (native) but I'm not sure how that works as it might result in the entire stack being printed.
There was a problem hiding this comment.
🙈, that would indeed be alot better.
Jessidhia
pushed a commit
to Jessidhia/yarn
that referenced
this pull request
Nov 4, 2016
* master: (66 commits) Add --no-bin-links flag - fixes yarnpkg#929 (yarnpkg#1651) Add option to change the prefix of the global bin folder - fixes yarnpkg#630 (yarnpkg#1654) patterns -> filteredPatterns Add helpful nudge to yarnpkg/rfcs on issue template (yarnpkg#1650) Change reporter.log to console.log in generate-lock-entry command - fixes yarnpkg#644 (yarnpkg#1652) Fixed add command flag (yarnpkg#1653) Nested executables fix (yarnpkg#1210) Added short-flags for yarn add (yarnpkg#1618) Add name lookups to ls command - fixes yarnpkg#1599 (yarnpkg#1643) Disable flaky secureUrl test (yarnpkg#1644) Add unit tests for `yarn why`. (yarnpkg#1544) Refine flow type for config.generateHardModulePath (yarnpkg#1642) Use ~/Library/Caches as default cache location on OSX - fixes yarnpkg#1637 (yarnpkg#1638) Update aliases.js (yarnpkg#1635) Update aliases.js (yarnpkg#1634) Add webhook to archive AppVeyor build artifacts (yarnpkg#1631) Attempt to fix failing Circle CI builds (yarnpkg#1629) Adding 'yarn global upgrade'(Issue yarnpkg#776) (yarnpkg#1616) Show error message in stdout. (yarnpkg#1502) Nicer permission errors when trying to write global binaries - fixes yarnpkg#1578 (yarnpkg#1592) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1456.
When an unexpected error occurres it now shows the error message in console. I also renamed the old unexpectedError string to bugReport and gave it an info flag.
Test plan
I tested this by setting the permissions of my package.json to read-only and then attempt to install a new package using
yarn add left-pad.Instead of outputting:
It now outputs: