Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name lookups to ls command - fixes #1599 #1643

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Add name lookups to ls command - fixes #1599 #1643

merged 1 commit into from
Nov 3, 2016

Conversation

sebmck
Copy link
Contributor

@sebmck sebmck commented Nov 3, 2016

No description provided.

@sebmck sebmck merged commit 65a2794 into master Nov 3, 2016
@sebmck sebmck deleted the ls-names branch November 3, 2016 11:46
Jessidhia pushed a commit to Jessidhia/yarn that referenced this pull request Nov 4, 2016
* master: (66 commits)
  Add --no-bin-links flag - fixes yarnpkg#929 (yarnpkg#1651)
  Add option to change the prefix of the global bin folder - fixes yarnpkg#630 (yarnpkg#1654)
  patterns -> filteredPatterns
  Add helpful nudge to yarnpkg/rfcs on issue template (yarnpkg#1650)
  Change reporter.log to console.log in generate-lock-entry command - fixes yarnpkg#644 (yarnpkg#1652)
  Fixed add command flag (yarnpkg#1653)
  Nested executables fix (yarnpkg#1210)
  Added short-flags for yarn add (yarnpkg#1618)
  Add name lookups to ls command - fixes yarnpkg#1599 (yarnpkg#1643)
  Disable flaky secureUrl test (yarnpkg#1644)
  Add unit tests for `yarn why`. (yarnpkg#1544)
  Refine flow type for config.generateHardModulePath (yarnpkg#1642)
  Use ~/Library/Caches as default cache location on OSX - fixes yarnpkg#1637 (yarnpkg#1638)
  Update aliases.js (yarnpkg#1635)
  Update aliases.js (yarnpkg#1634)
  Add webhook to archive AppVeyor build artifacts (yarnpkg#1631)
  Attempt to fix failing Circle CI builds (yarnpkg#1629)
  Adding 'yarn global upgrade'(Issue yarnpkg#776) (yarnpkg#1616)
  Show error message in stdout. (yarnpkg#1502)
  Nicer permission errors when trying to write global binaries - fixes yarnpkg#1578 (yarnpkg#1592)
  ...
@SimenB
Copy link
Contributor

SimenB commented Nov 11, 2016

Doesn't seem to work.

$ npm ls yargs
finnlet-server@1.0.0 /Users/simbekkh/repos/finnlet-server
└─┬ pug@2.0.0-beta6
  └─┬ pug-filters@1.2.4
    └─┬ uglify-js@2.7.4
      └── yargs@3.10.0
$ ../yarn/bin/yarn.js ls yargs
yarn ls v0.17.0-0
error Couldn't find package "yargs".
info Visit https://yarnpkg.com/en/docs/cli/ls for documentation about this command.

Local yarn is 286efb9, with ./scripts/build-dist.sh ran

@SimenB
Copy link
Contributor

SimenB commented Nov 11, 2016

Doing just ls works

$ ../yarn/bin/yarn.js ls
...
└─ yargs@4.8.1
│  ├─ cliui@^3.2.0
│  ├─ decamelize@^1.1.1
│  ├─ get-caller-file@^1.0.1
│  ├─ lodash.assign@^4.0.3
│  ├─ os-locale@^1.4.0
│  ├─ read-pkg-up@^1.0.1
│  ├─ require-directory@^2.1.1
│  ├─ require-main-filename@^1.0.1
│  ├─ set-blocking@^2.0.0
│  ├─ string-width@^1.0.1
│  ├─ which-module@^1.0.0
│  ├─ window-size@^0.2.0
│  ├─ y18n@^3.2.1
│  └─ yargs-parser@^2.4.1
✨  Done in 0.63s.
$ ./yarn/bin/yarn.js ls | grep yargs
│  ├─ yargs@~3.27.0
│  └─ yargs@3.27.0
│  ├─ yargs-parser@3.2.0
│  ├─ yargs@^5.0.0
│  └─ yargs@5.0.0
│  │  └─ yargs-parser@^3.2.0
│  ├─ yargs-parser@3.2.0
│  ├─ yargs@^5.0.0
│  └─ yargs@5.0.0
│  │  └─ yargs-parser@^3.2.0
│  ├─ yargs@~3.10.0
│  └─ yargs@3.10.0
│  └─ yargs@^4.7.1
├─ yargs-parser@2.4.1
└─ yargs@4.8.1
│  └─ yargs-parser@^2.4.1

EDIT: OK, it works for top level deps, but not deps of deps.

I'd like to to e.g. yarn ls minimatch when old minimatches are used, to find out which package uses a vulnerable one.

It's still a bit weird, though

$ ../yarn/bin/yarn.js ls graphql
yarn ls v0.17.0-0
├─ graphql@0.6.2
│  └─ iterall@1.0.2
└─ iterall@1.0.2
✨  Done in 0.27s.

Why is iterall there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants