Attempt to fix failing Circle CI builds #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... We probably shouldn't be running tests that can take up to 90 seconds as part of every single commit or PR, as it makes the feedback loop slower. This would be better suited for a nightly test run or something like that. I'm going to be running some nightly end-to-end tests (see https://github.com/yarnpkg/yarn/tree/master/end_to_end_tests), maybe we could also categorise some tests as "slow" tests and not run them as part of CI. |
|
Granted this was a bandaid fix, but this timeout of 90 seconds is also defined in a lot of other test files. |
Jessidhia
pushed a commit
to Jessidhia/yarn
that referenced
this pull request
Nov 4, 2016
* master: (66 commits) Add --no-bin-links flag - fixes yarnpkg#929 (yarnpkg#1651) Add option to change the prefix of the global bin folder - fixes yarnpkg#630 (yarnpkg#1654) patterns -> filteredPatterns Add helpful nudge to yarnpkg/rfcs on issue template (yarnpkg#1650) Change reporter.log to console.log in generate-lock-entry command - fixes yarnpkg#644 (yarnpkg#1652) Fixed add command flag (yarnpkg#1653) Nested executables fix (yarnpkg#1210) Added short-flags for yarn add (yarnpkg#1618) Add name lookups to ls command - fixes yarnpkg#1599 (yarnpkg#1643) Disable flaky secureUrl test (yarnpkg#1644) Add unit tests for `yarn why`. (yarnpkg#1544) Refine flow type for config.generateHardModulePath (yarnpkg#1642) Use ~/Library/Caches as default cache location on OSX - fixes yarnpkg#1637 (yarnpkg#1638) Update aliases.js (yarnpkg#1635) Update aliases.js (yarnpkg#1634) Add webhook to archive AppVeyor build artifacts (yarnpkg#1631) Attempt to fix failing Circle CI builds (yarnpkg#1629) Adding 'yarn global upgrade'(Issue yarnpkg#776) (yarnpkg#1616) Show error message in stdout. (yarnpkg#1502) Nicer permission errors when trying to write global binaries - fixes yarnpkg#1578 (yarnpkg#1592) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumping the timeout seemed to do the trick for me here: https://circleci.com/gh/yarnpkg/yarn/1906
Test plan
Circle CI builds are green again.