Suppress warning when package sets engines.pnpm #7566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ant59
approved these changes
Oct 10, 2019
RinMinase
approved these changes
Nov 12, 2019
|
Hey @arcanis! May I know what's the status of this? 😁 |
|
Closing as Yarn 1 is in maintenance and this PR is not relevant for Angular CLI anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7560
Summary
Suppress warning for engines.pnpm similar to other alternative package managers, which will never be satisfied by Yarn.
Test plan
Tested locally by running
yarn-local add @angular/cli@9.0.0-next.5and observing that there are no warnings printed.