-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid warning when pnpm
is used as an engine field
#7560
Comments
On Ubuntu as well
|
Closing as fixed in v2 where we don't warn on invalid engines anymore. |
@paul-soporan: Is |
It was released a few years ago, 2020-01-24 |
@merceyz: But why do I have |
Read the migration guide that @paul-soporan linked to in #7560 (comment) |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Adding a package which has
pnpm
listed as an engine in itspackage.json
results in a warning:The engine "pnpm" appears to be invalid.
If the current behavior is a bug, please provide the steps to reproduce.
Add a package which lists
pnpm
as an engine in itspackage.json
.What is the expected behavior?
No warning should be shown.
The
pnpm
value should be ignored as isnpm
here: https://github.com/yarnpkg/yarn/blob/master/src/package-compatibility.js#L50Please mention your node.js, yarn and operating system version.
Node.js: 10.10.0
yarn: 1.17.3
OS: macOS 10.14.6
The text was updated successfully, but these errors were encountered: