set more connection config attributes #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
approved these changes
Jul 24, 2019
| @@ -58,12 +60,17 @@ def self.for(type) | |||
| # | |||
| # Load with reasonable defaults | |||
| # @param type [Y2Network::InterfaceType] type of device | |||
| def initialize(type:) | |||
| # @param config [Y2Network::ConnectionConfig::Base] existing configuration of device or nil for | |||
There was a problem hiding this comment.
np: Just add the , nil there.
|
|
||
| # connection config | ||
| # keep only default as aliases does not handle default ip config | ||
| @connection_config.ip_configs.delete_if { |c| c.id != "" } |
There was a problem hiding this comment.
We could add ConnectionConfig::Base#main_ip_config and ConnectionConfig::Base#aliases (or something like this) so you do not have to worry about this.
There was a problem hiding this comment.
yep, when added, feel free to change this code ;)
| # in such case remove default config | ||
| @connection_config.ip_configs.delete_if { |c| c.id == "" } | ||
| else | ||
| ip_config_default.address.address = value |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.