Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network-ng: complete new backend #976

Merged
merged 573 commits into from
Sep 30, 2019
Merged

network-ng: complete new backend #976

merged 573 commits into from
Sep 30, 2019

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Sep 20, 2019

This PR contains a lot of changes from the network-ng branch (yast2-network refactoring). In a nutshell, we have completed and switched to the new backend. Additionally, we have dropped a lot of old code.

See the design document to get an overview.

Included Pull Requests

jreidinger and others added 30 commits September 2, 2019 17:12
* See pr#935 for further details.
* It fixes reading of unnamed interfaces (like s390 ones)
remove old firewall zone value
* LanItems.add_device_to_routing is not used anymore.
* For the time being, implementation for PhysicalInterface and VirtualInterface
  would be the same.
@coveralls
Copy link

coveralls commented Sep 20, 2019

Coverage Status

Coverage increased (+6.0%) to 67.949% when pulling 7671f5b on network-ng into 58daf40 on master.

@mvidner
Copy link
Member

mvidner commented Sep 26, 2019

I am reviewing this already but so far I have nothing to complain about! How dare you?!

@mvidner mvidner mentioned this pull request Sep 30, 2019
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the class architecture, and it makes good sense!

I ended up with small improvements in the documentation, filed as a separate PR #981 .

@imobachgs
Copy link
Contributor Author

Thanks a ton, @mvidner! I will merge the PR.

@imobachgs imobachgs merged commit 90bf250 into master Sep 30, 2019
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #77 successfully finished
✔️ Created OBS submit request #734094

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #8 successfully finished
✔️ Created IBS submit request #202020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants