Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network-ng: split IP configurations into #ip and #ip_aliases #907

Merged
merged 9 commits into from
Aug 1, 2019
Merged

network-ng: split IP configurations into #ip and #ip_aliases #907

merged 9 commits into from
Aug 1, 2019

Conversation

imobachgs
Copy link
Contributor

Separate ConnectionConfig::Base#ip_configs into different methods: #ip and #ip_aliases.

@imobachgs imobachgs force-pushed the network-ng-split-ip-configs branch from 7756279 to d24e5f9 Compare July 30, 2019 16:00
@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 64.601% when pulling 94be3e0 on network-ng-split-ip-configs into 58e1de5 on network-ng.

@imobachgs imobachgs force-pushed the network-ng-split-ip-configs branch from d24e5f9 to 2a181d1 Compare July 31, 2019 12:01
@imobachgs imobachgs changed the base branch from network-ng-use-connection-config-writers to network-ng July 31, 2019 14:50
@imobachgs imobachgs force-pushed the network-ng-split-ip-configs branch from 95cc27f to 04eb764 Compare July 31, 2019 14:57
@imobachgs imobachgs force-pushed the network-ng-split-ip-configs branch from 04eb764 to 90d97d7 Compare July 31, 2019 15:22
@imobachgs imobachgs marked this pull request as ready for review July 31, 2019 15:22
@imobachgs imobachgs changed the title network-ng: split ip configs network-ng: split IP configurations into #ip and #ip_aliases Jul 31, 2019
teclator
teclator approved these changes Aug 1, 2019
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imobachgs imobachgs merged commit 1a2ab8a into network-ng Aug 1, 2019
@imobachgs imobachgs deleted the network-ng-split-ip-configs branch August 1, 2019 09:13
@imobachgs imobachgs mentioned this pull request Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imobachgs @coveralls @teclator