New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network-ng: Added ctc connection config #916
Conversation
teclator
commented
Aug 5, 2019
•
edited
edited
- https://trello.com/c/DT4tgPgw/1145-3-add-missing-connectionconfig-classes
a2bca0f
to
d336478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks good to me. My only concern is whether it makes sense to have a reader/writer which do not implement update_file
or update_connection_config
.
attr_accessor :write_channel | ||
# @return [Integer] connection protocol (0, 1, 3, or 4) | ||
# 0 Compatibility with peers other than OS/390®. | ||
# 1 Enhanced package checking for Linux peers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curiosity: where is the number "2"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably does not make sense in Linux. To be honest, No idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -23,6 +23,39 @@ module Y2Network | |||
module ConnectionConfig | |||
# Configuration for qeth connections | |||
class Qeth < Base | |||
# For CCW devices and CCW group devices, this device ID is the device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be clear, the "read channel" is the "device ID" you are talking about, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the device ID is for both, the read channel and write channel. That is for example "0.0.8000" is the read channel device id and "0.0.8001" is the write channel device id.
https://www.ibm.com/support/knowledgecenter/linuxonibm/com.ibm.linux.z.lgdd/lxctcrot.jpg
https://github.com/SUSE/s390-tools/blob/master/ctc_configure#L10
The thing is that each connection looks for a reader or writer of its class, when all of them does not have a particular reader or writer. That is, will use mainly the same base options. |
I will merge it as it is. But will create a macro with ccw group device information in next PR to add to s390 connnection config types. |