network-ng: drop fake interface #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It fixes reading of unnamed interfaces (like s390 ones)
jreidinger
reviewed
Sep 3, 2019
| # | ||
| # @return [Boolean] | ||
| def present? | ||
| !!type |
There was a problem hiding this comment.
is type really so deterministic? I though that type could be part of udev rule, not? What about dev_name?
There was a problem hiding this comment.
I would say that the type is always there (but perhaps there is a better candidate) and, from udev, we are only able to infer the bus ID and the MAC. On the other hand, we want to avoid the dev_name because it might be missing (s390) and that's the main problem we try to address.
jreidinger
approved these changes
Sep 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method improves
Y2Network::HwinfoAPI adding a#netcardsmethod and implementing memoization. It does not have any performance impact because, at this time, the hardware info is stored inLanItemsanyway.Additionally, the hardware info is passed to
PhysicalInterfacethrough its constructor. It solves a problem where, although we had the hardware info for unnamed interfaces, thePhysicalInterfacewas unable to find it because of the missing name.