Allow to select no driver (auto) #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Sep 16, 2019
src/lib/y2network/driver.rb
Outdated
| @@ -70,6 +70,7 @@ def initialize(name, params = "") | |||
| # @param other [Driver] Driver to compare with | |||
There was a problem hiding this comment.
please document that it can accept also non Driver
jreidinger
reviewed
Sep 16, 2019
| subject.save | ||
| end | ||
|
|
||
| it "does not update any driver" do |
There was a problem hiding this comment.
do we want not update or explicit udev rule delete?
There was a problem hiding this comment.
This one is about setting the Driver options.
jreidinger
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests I ended in this scenario: let's say that I select a
customdriver for a given interface, which caused a udev rule to be written. The next time that I open the hardware dialog again, I can only switch between thecustomand thevirtio_netdriver. But, in both cases, a udev rule will be written (or updated). But what I want to do is to not force any driver at all. The only option is to manually delete the file.As a solution, I have extended the drivers dialog to support an
autooption, in which case no udev rule is written (and the kernel will decide which module to use).