Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect that connections changed and fix removal of it #966

Merged
merged 5 commits into from Sep 18, 2019
Merged

detect that connections changed and fix removal of it #966

merged 5 commits into from Sep 18, 2019

Conversation

jreidinger
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Sep 18, 2019 •
edited

Coverage Status

Coverage decreased (-0.09%) to 66.128% when pulling a6a8c88 on fix_connection_removal into 0f141be on network-ng.

imobachgs
imobachgs reviewed Sep 18, 2019
View reviewed changes
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise it looks good (just minor things). However, I would like to see a unit test probing that the file is removed.

test/y2network/sysconfig/config_writer_test.rb Outdated Show resolved Hide resolved
src/lib/y2network/sysconfig/connection_config_writer.rb Show resolved Hide resolved
@jreidinger jreidinger merged commit 7082a80 into network-ng Sep 18, 2019
@jreidinger jreidinger deleted the fix_connection_removal branch September 18, 2019 13:39
@imobachgs imobachgs mentioned this pull request Sep 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imobachgs imobachgs imobachgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jreidinger @coveralls @imobachgs