-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include some hints in the "Priority" label (bsc#1154693) #482
Conversation
@mvidner What do you think about this label? Is it OK? Or any better suggestion? |
It's hard, I don't see a way to make it obvious and unmistakable. Let's see how the world sees "priority" |
You have missed an important aspect of the bug report: the priority changing widget is an IntField which has arrows: an up arrow raises the number, which lowers the priority. That contributes to the confusion.
|
An editable combo box looks like an interesting alternative... I'll check that later. |
How about renaming "Priority" field to "Weight"? |
BTW on Leap 15.2, "zypper addrepo ..." tells me
|
Ah, now I understand! I have interpreted "Repository priorities are without effect." as "the priority feature is gone, zypp ignores whatever priority you specify", but the source code and the following example show that it in fact means "the currently enabled repositories happen to share the same priority, so I am confusing you with superfluous information. If you add a repo with a different priority I will remind you too which will be much more useful." # LANG=C z ar -p 50 /tmp tmp50
Adding repository 'tmp50' ...............................................[done]
Repository 'tmp50' successfully added
URI : dir:/tmp
Enabled : Yes
GPG Check : Yes
Autorefresh : No
Priority : 50 (raised priority)
Repository priorities in effect: (See 'zypper lr -P' for details)
50 (raised priority) : 1 repository
99 (default priority) : 13 repositories |
Um, it's basically just waiting for the @mvidner 's approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is an easy improvement
✔️ Public Jenkins job #158 successfully finished |
✔️ Internal Jenkins job #86 successfully finished |
The Problem
Solution
Screenshots
(I deliberately installed the French translations as they are usually longer.)
Small window (80x25), the short label is used (cough, cough, it already fits so so...):
![repo_priority_short](https://user-images.githubusercontent.com/907998/67287221-fb704e80-f4da-11e9-9811-8c65eeafb872.png)
Larger window, the new longer label is used (obviously not translated yet):
![repo_priority_long](https://user-images.githubusercontent.com/907998/67287232-00cd9900-f4db-11e9-93df-cf2c82954920.png)
In GUI it always uses the longer version, there should be almost always enough space (this is in 800x600):
![repo_priority_qt](https://user-images.githubusercontent.com/907998/67281682-46389900-f4d0-11e9-929f-c1affc4e8aa5.png)