[Review] Request from 'schubi2' @ 'yast/yast-yast2/review_180112_miss…

…ing_package' (#668) * return empty hash if package has not been installed
yast · Jan 12, 2018 · aa6d6b3 · aa6d6b3
1 parent 76d04b5
commit aa6d6b3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/library/network/src/lib/y2firewall/firewalld.rb b/library/network/src/lib/y2firewall/firewalld.rb
@@ -102,6 +102,7 @@ def write
     #
     # @return [Hash] dump firewalld settings
     def export
+      return {} unless installed?
       {
         "default_zone"       => default_zone,
         "log_denied_packets" => log_denied_packets,

diff --git a/package/yast2.changes b/package/yast2.changes
@@ -1,3 +1,10 @@
+-------------------------------------------------------------------
+Fri Jan 12 14:13:38 CET 2018 - schubi@suse.de
+
+- Firewalld export: Return empty hash if the package has not
+  been installed. (fate#323460)
+- 4.0.34
+
 -------------------------------------------------------------------
 Wed Jan 10 17:24:18 CET 2018 - schubi@suse.de
 

diff --git a/package/yast2.spec b/package/yast2.spec
@@ -16,7 +16,7 @@
 #
 
 Name:           yast2
-Version:        4.0.33
+Version:        4.0.34
 Release:        0
 Summary:        YaST2 - Main Package
 License:        GPL-2.0