Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Review] Request from 'schubi2' @ 'yast/yast-yast2/review_180112_missing_package' #668

Merged
merged 2 commits into from
Jan 12, 2018
Merged

[Review] Request from 'schubi2' @ 'yast/yast-yast2/review_180112_missing_package' #668

merged 2 commits into from
Jan 12, 2018

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Jan 12, 2018

Please review the following changes:

  • 406c04e return empty hash if package has not been installed

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 25.456% when pulling dbd1b48 on review_180112_missing_package into 76d04b5 on master.

teclator
teclator approved these changes Jan 12, 2018
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schubi2 schubi2 merged commit aa6d6b3 into master Jan 12, 2018
@imobachgs imobachgs deleted the review_180112_missing_package branch July 6, 2018 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schubi2 @coveralls @teclator