Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use linuxrc option reboot_timeout to configure the timeout before reboot #1159

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Use linuxrc option reboot_timeout to configure the timeout before reboot #1159

merged 2 commits into from
Apr 29, 2021

Conversation

dzedro
Copy link
Contributor

@dzedro dzedro commented Apr 27, 2021 •
edited
Loading

This was referenced Apr 27, 2021
Merged
Merged
@coveralls
Copy link

coveralls commented Apr 27, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 28.375% when pulling 6a28935 on dzedro:reboot_timeout into 166f96d on yast:SLE-15-SP1.

@teclator
Copy link
Contributor

Basically it backports #977 but probably it also need to backport this one #984

teclator
teclator approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

teclator
teclator requested changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you already backported #984 and #986 but I think you have not commited them yet

teclator
teclator approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teclator teclator merged commit 793a453 into yast:SLE-15-SP1 Apr 29, 2021
@dzedro dzedro deleted the reboot_timeout branch April 29, 2021 12:07
@teclator teclator mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dzedro @coveralls @teclator