Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linuxrc option reboot_timeout to configure before reboot (bsc#1122493) #977

Merged
merged 1 commit into from Nov 5, 2019

Conversation

okurz
Copy link
Contributor

@okurz okurz commented Oct 31, 2019

No description provided.

@coveralls
Copy link

coveralls commented Oct 31, 2019

Coverage Status

Coverage increased (+0.002%) to 29.134% when pulling 2b0aaaa on okurz:feature/reboot_timeout into 46532b7 on yast:master.

@jreidinger
Copy link
Member

now it looks good, just rubocop failing. But it has autocorrection, so you should be fine when running rake check:rubocop:auto_correct or you can do it manually by adding line after return at https://github.com/yast/yast-yast2/pull/977/files#diff-b8b68eb2ba2e5a979f2a541dff73c387R145

@okurz
Copy link
Contributor Author

okurz commented Nov 5, 2019

Thank you for mentoring me in the process :) All green now

@jreidinger
Copy link
Member

@okurz you are welcome and thanks for patch.

@jreidinger jreidinger merged commit 9e8ca5c into yast:master Nov 5, 2019
@yast-bot
Copy link
Contributor

yast-bot commented Nov 5, 2019

✔️ Internal Jenkins job #41 successfully finished
✔️ Created IBS submit request #204459

@yast-bot
Copy link
Contributor

yast-bot commented Nov 5, 2019

✔️ Public Jenkins job #141 successfully finished
✔️ Created OBS submit request #745531

@okurz okurz deleted the feature/reboot_timeout branch November 6, 2019 19:32
teclator pushed a commit that referenced this pull request Apr 29, 2021
Add linuxrc option reboot_timeout to configure before reboot (bsc#1122493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants