-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New rubocop #1230
New rubocop #1230
Conversation
…(I spend 5 minutes to reading and understanding this hell code)
name = one_module["name"] | ||
proposal = one_module["proposal"] | ||
|
||
next true if name && !name.empty? | ||
next true if proposal && !proposal.empty? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better now 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Public Jenkins job #345 successfully finished |
✔️ Internal Jenkins job #182 successfully finished |
No description provided.