Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rubocop #1230

Merged
merged 14 commits into from
Jan 12, 2022
Merged

New rubocop #1230

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
763f8d5
adapt rubocop config
jreidinger Jan 6, 2022
ded6ca4
safe auto corrections
jreidinger Jan 6, 2022
826cb04
unsafe auto corrections ( manually reviewed )
jreidinger Jan 7, 2022
d6c93b6
fix redundant branch cop. It is a bit buggy for workflow encoded in e…
jreidinger Jan 7, 2022
2c579c9
fix calling super in important methods
jreidinger Jan 7, 2022
ab04261
fix method naming convention cop
jreidinger Jan 7, 2022
953c3a6
fix document dynamic eval cop
jreidinger Jan 7, 2022
745a207
fix empty block cop
jreidinger Jan 7, 2022
71d7b40
fix Style/CombinableLoops cop
jreidinger Jan 7, 2022
6866413
fix bug found by Lint/DuplicateElsifCondition as condition was wrong …
jreidinger Jan 7, 2022
687fb66
disable cop for optional boolean parameters to avoid API changes
jreidinger Jan 7, 2022
a669b19
Merge remote-tracking branch 'origin/master' into new_rubocop
jreidinger Jan 11, 2022
9d8e6d7
fixes to super
jreidinger Jan 11, 2022
a6fd7c7
rubocop fixes
jreidinger Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions library/network/src/modules/PortRanges.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ def FlattenServices(old_list, protocol)
new_min = nil
new_max = nil
# rubocop:disable Lint/DuplicateBranch
# wrong detection of dupliate branch as if cause logic and workflow
# wrong detection of duplicate branch as if cause logic and workflow
# the second one is inside the first one
if Ops.less_or_equal(min_pr, this_min_pr) &&
Ops.greater_or_equal(max_pr, this_max_pr)
Expand All @@ -586,7 +586,7 @@ def FlattenServices(old_list, protocol)
new_max = this_max_pr
# the second one partly covers the first one (by its left side)
elsif Ops.greater_or_equal(min_pr, this_min_pr) &&
Ops.less_or_equal(max_pr, this_max_pr)
Ops.greater_or_equal(max_pr, this_max_pr)
dgdavid marked this conversation as resolved.
Show resolved Hide resolved
# take this_min_pr & max_pr
any_change_during_this_loop = true
new_min = this_min_pr
Expand Down