Add .find! methods to system unit modules #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def find! service_name, properties={} | ||
| service = find(service_name, properties) | ||
| return service if service | ||
| raise SystemdServiceNotFound, "Service unit '#{service_name}' not found" |
There was a problem hiding this comment.
well, you can use also one-liner with || or or
find(service_name, properties) or raise SystemdServiceNotFound, "Service unit '#{service_name}' not found"
There was a problem hiding this comment.
Agree, but its 107 characters, you would have to split it into 2 lines to make it fit into a common editor or github window.
There was a problem hiding this comment.
ok, just nitpick. In fact I expect that you have own constructor for exception and pass only service_name.
then it will look like
find(service_name, properties) or raise(SystemdServiceNotFound, service_name)
There was a problem hiding this comment.
Good point, thanks, I will adapt the exception classes.
|
just small style nitpick, LGTM |
vmoravec
pushed a commit
that referenced
this pull request
Mar 7, 2014
Add .find! methods to system unit modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reasoning behind this is:
If you can't handle any
nilat the place of calling, use the finder with exclamation mark;SystemdSocketNotFoundorSystemdServiceNotFoundexception will be raised.