Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merged with sles15 #738

Closed
wants to merge 1 commit into from
Closed

merged with sles15 #738

wants to merge 1 commit into from

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented May 23, 2018

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0009%) to 29.06% when pulling d7927dd on review_180523_merged_with_sles15 into e523160 on master.

mchf
mchf approved these changes May 24, 2018
View reviewed changes
Copy link
Member

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me but Travis was unhappy for some reason. I've restarted the build. Lets see what happens.

@mchf
Copy link
Member

mchf commented May 24, 2018

Ah now I see ... a test is failing.

mchf
mchf requested changes May 24, 2018
View reviewed changes
Copy link
Member

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the tests

@schubi2
Copy link
Member Author

schubi2 commented Dec 11, 2018

Assuming that is has been merged meanwhile in another point

@schubi2 schubi2 closed this Dec 11, 2018
@schubi2 schubi2 deleted the review_180523_merged_with_sles15 branch December 11, 2018 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchf mchf mchf requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schubi2 @coveralls @mchf