crds: add last syn to vol rep status #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yati1998
force-pushed
the
lastsync
branch
2 times, most recently
from
6c92b40
to
9abae5b
Compare
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.1 to 1.20.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.1...v1.20.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.12.3 to 0.13.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.12.3...v0.13.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.70.1 to 2.80.1. - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.70.1...v2.80.1) --- updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
This commit adds lastsynctime to volume replicationstatus and updates the crds. Signed-off-by: yati1998 <ypadia@redhat.com>
This commit creates internal grpc to get volume replication information. Signed-off-by: yati1998 <ypadia@redhat.com>
this commit updates the vendor to get latest spec. Signed-off-by: yati1998 <ypadia@redhat.com>
This commit adds reconcile logic to update the last sync time. Signed-off-by: yati1998 <ypadia@redhat.com>
Bumps [google.golang.org/grpc/cmd/protoc-gen-go-grpc](https://github.com/grpc/grpc-go) from 1.1.0 to 1.2.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@cmd/protoc-gen-go-grpc/v1.1.0...v1.2.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc/cmd/protoc-gen-go-grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.25.0 to 0.25.1. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.25.0...v0.25.1) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.0 to 0.25.1. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.25.0...v0.25.1) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: helm/kind-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/api](https://github.com/kubernetes/api) from 0.25.1 to 0.25.2. - [Release notes](https://github.com/kubernetes/api/releases) - [Commits](kubernetes/api@v0.25.1...v0.25.2) --- updated-dependencies: - dependency-name: k8s.io/api dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [k8s.io/client-go](https://github.com/kubernetes/client-go) from 0.25.1 to 0.25.2. - [Release notes](https://github.com/kubernetes/client-go/releases) - [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md) - [Commits](kubernetes/client-go@v0.25.1...v0.25.2) --- updated-dependencies: - dependency-name: k8s.io/client-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.9.2 to 0.10.0. - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.9.2...v0.10.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Niels de Vos <ndevos@redhat.com>
resolveEndpoint get the pod object to resolve the ip address as the pod object is deleted resolveEndpoint will fail to get the pod and it blocks the csiaddonsnodes object from getting deleted because of this logs will get flooded and other csiaddons operation might also fail. To fix this problem call resolveEndpoint only if the csiaddonsnodes object is not deleted. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.2 to 1.21.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.2...v1.21.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.49.0 to 1.50.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.49.0...v1.50.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
add nodeID to error message to provide more details for debugging. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.25.2 to 0.25.3. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.25.2...v0.25.3) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.50.0 to 1.50.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.50.0...v1.50.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [github.com/operator-framework/operator-sdk](https://github.com/operator-framework/operator-sdk) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/operator-framework/operator-sdk/releases) - [Changelog](https://github.com/operator-framework/operator-sdk/blob/master/.goreleaser.yml) - [Commits](operator-framework/operator-sdk@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: github.com/operator-framework/operator-sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
remoce CreateFunc predicate to accomudate reading annotations from the namespaces. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Currently, we only support the reclaimspace feature on the PVC annotation. However, this adds support for namespace annotations as well. If the required PVC annotation is missing, our controller will check if the necessary annotation is present on the namespace. If it is, the scheduling details will be retrieved from the namespace annotation and used to create the ReclaimspaceCronJob. It's important to note that the PVC annotation will take precedence over namespace annotations. Please be aware that we can only create a reclaimspaceCronJob if the annotation exists on the namespace. If an admin wants to update or remove the annotation on the namespace, the same action must be taken on all the PVCs within that namespace. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Updated the documentation for the namespace annotation for the ReclaimSpace operation. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
This commit adds support to specify timeout for reclaimspace operation in `reclaimspacejob.spec`. The time taken by reclaimspace operation on each PVC vary according to its size, data and io patterns. Therefore, each PVC may need a different timeout for this operation. Signed-off-by: Rakshith R <rar@redhat.com>
Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.3 to 1.8.4. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.3...v1.8.4) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Based on the example in the golangci-lint GitHub Action documentnation. See-also: https://github.com/golangci/golangci-lint-action Signed-off-by: Niels de Vos <ndevos@ibm.com>
…bHook validation golangci-lint complains that `rscjLog` is not used. This seems to be correct, as the validating WebHook for ReclaimSpaceCronJob used the wrong logger. Signed-off-by: Niels de Vos <ndevos@ibm.com>
…rDriverNotFound` The `errDriverNotFound` error is not used anymore. Signed-off-by: Niels de Vos <ndevos@ibm.com>
…in `Deploy()` `Deploy()` always returns `nil`, even when `wait.PollImmediateInfinite()` would return an error. At the moment, no errors are returned while polling, everything seems to be handled. In case this changes in the future, the error will be returned now. Signed-off-by: Niels de Vos <ndevos@ibm.com>
golangci-lint noticed thet `getSecret()` is not used. There probably is no need for this function in `main.go` anyway, it would probably be cleaner to fetch a Secret in the Controller or Side-Car when it is needed. Signed-off-by: Niels de Vos <ndevos@ibm.com>
golangci-lint reports that `grpc.WithInsecure()` has been deprecated. It can be replaced by `grps.WithTransportCredentials() and pass credentials created with `insecure.NewCredentials()`. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
golangci-lint complains that `cfg` is not used. Other unit-tests use the global `cfg` variable, so use that in the controller test suite too. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Niels de Vos <ndevos@ibm.com>
When kubernetes-csi-addons are included in the ODF product, we need to document the review/backport guidelines and list the maintainers. This repository is currently part of the responsibilities of the Ceph-CSI team. Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 6b32ad6)
Dependabot does not need to report available updates for vendored dependencies in the downstream repository. Updates to dependencies are synced from the upstream repository when needed. There is also the "Upstream First" requirement, which we follow closely. See-also: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/configuration-options-for-dependency-updates#open-pull-requests-limit Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 6e4f4ba)
As ODF-Operator is used for deploying the CSI-Addons components, the CSI-Addons operator does not need to be visible in the OperatorHub. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2042997 Signed-off-by: Niels de Vos <ndevos@redhat.com> (cherry picked from commit 15e9b1a)
There is no upstream icon for the CSI-Addons project yet. All operators are required to have an icon before they can be published. Until there is an icon in upstream, use the standard Red Hat icon for product builds. Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commits add instructions to resolve conflicts if they arise while syncing upstream changes. Signed-off-by: Rakshith R <rar@redhat.com>
Yug left the company, so removing him from the team. Signed-off-by: Niels de Vos <ndevos@redhat.com>
Depandabot automatic updating for GitHub Actions is not wanted. Changes should flow in from the upstream repository instead. See-also: 945da36 Signed-off-by: Niels de Vos <ndevos@redhat.com>
This commit adds the lastsyncbytes and lastsyncduration to the volume replication status. Signed-off-by: yati1998 <ypadia@redhat.com>
This commit update the getvolmereplicationinfo RPC to get the lastsyncbytes and lastsyncduration. It also updates the protoc version in other files. Signed-off-by: yati1998 <ypadia@redhat.com>
This commit updates the vendor directory to include the latest spec changes Signed-off-by: yati1998 <ypadia@redhat.com>
this commit updates the reconcile logic to update the lastsyncbytes and lastsyncduration along with the lastsynctime to the volrep status Signed-off-by: yati1998 <ypadia@redhat.com>
This commit add duration.proto file to internal/google.protobuf to enable the usage of duration Signed-off-by: yati1998 <ypadia@redhat.com>
This commits adds support for configuration options consumed through a optional configmap. This will enable users to create a configmap to supply options that are persisted throughout upgrades. Current support parameters are `"reclaim-space-timeout"` and `"max-concurrent-reconciles"`. Signed-off-by: Rakshith R <rar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds lastsynctime to volume
replicationstatus and updates the crds.
Signed-off-by: yati1998 ypadia@redhat.com