Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest code not build even after putting jstock.jar #111

Closed
anujrathi26 opened this issue Nov 20, 2017 · 4 comments
Closed

latest code not build even after putting jstock.jar #111

anujrathi26 opened this issue Nov 20, 2017 · 4 comments

Comments

@anujrathi26
Copy link

These are not found in latest code even after putting jstock.jar
1.org.yccheok.jstock.engine.Utils.clearGoogleCodeDatabaseCache();
2. org.yccheok.jstock.engine.Utils.isGoogleCodeDatabaseRequired(country)
3. GoogleCodeDatabaseRunnable(country)
32855599-2a97b472-ca68-11e7-8316-b8cad1853dd7

@yccheok
Copy link
Owner

yccheok commented Mar 6, 2018

Due to complicated legal issue, we decides not to release certain code block.

We should release some binary library, to make the source code build-able.

However, we are pretty much busy with other higher priority thing. Hence, we don't have an estimated timeline on when the binary library will be available.

@rkraneis
Copy link

rkraneis commented Mar 2, 2020

Any news here, @yccheok ? Also, you may want to change the claim It's free and open source on the homepage. In the current state it's not. I only found out by using git bisect and ending up at

8df5fb6 is the first bad commit
commit 8df5fb6
Author: Yan Cheng Cheok yccheok@yahoo.com
Date: Sat Jul 25 22:44:29 2015 +0800

org.yccheok.jstock.engine will be closed source component.

@rkraneis
Copy link

rkraneis commented Mar 2, 2020

(And don't get me wrong: your code, your rules ;-) But having GPL V2 in docs and as file headers kind of sends the wrong signal to possible contributors)

@yccheok
Copy link
Owner

yccheok commented Mar 2, 2020

I just remove the open source wording - yccheok/yccheok.github.io@de57039

I also updated README with wording

JStock is NOT a fully open source project. Some of the code components are closed source. You will NOT able to compile JStock even after downloading source code from here.

@yccheok yccheok closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants