Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot override/unset defaults for g:ycm_semantic_triggers #33

Closed
blueyed opened this issue Sep 7, 2014 · 1 comment
Closed

Cannot override/unset defaults for g:ycm_semantic_triggers #33

blueyed opened this issue Sep 7, 2014 · 1 comment

Comments

@blueyed
Copy link

blueyed commented Sep 7, 2014

Code: https://github.com/Valloric/ycmd/blob/master/ycmd/completers/completer_utils.py#L26-L31

user_trigger_map correspondents to the g:ycm_semantic_triggers here, and gets merged with PREPARED_DEFAULT_FILETYPE_TRIGGERS.

Therefore it's not possible anymore to unset/change the filetype triggers for a specific filetype.

Also, this recent change (merging the settings) appears to be not backwards-compatible in that g:ycm_semantic_triggers was taken as-is before, without merging it with the defaults.

@Valloric
Copy link
Member

Valloric commented Sep 8, 2014

Therefore it's not possible anymore to unset/change the filetype triggers for a specific filetype.

This was changed many months ago and is working as intended. Yes, you can't turn off default semantic triggers anymore; people were turning them off by accident when they would redefine the dict to add triggers for a random language. Removing some default semantic triggers for a language was thus a rarely used feature that was removed because it did more harm than good (people were shooting themselves in the foot).

The whole idea of user-level custom semantic triggers was a bad one and I'd take it back if I could without breaking people. It results in people locally setting semantic triggers for a language YCM doesn't have good defaults instead of upstreaming their changes and improving the defaults. This is the reason why there's no user-level option for tweaking the new per-language identifier regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants