[READY] update Typescript to 3.5.1 - fixes #1260

[pabra]

This change is 

[bstaletic]

Thanks for the PR.

Simply changing the the version will break a test. To fix it apply the patch below:

diff --git a/ycmd/tests/typescript/subcommands_test.py b/ycmd/tests/typescript/subcommands_test.py
index 83f75d66..cff218fb 100644
--- a/ycmd/tests/typescript/subcommands_test.py
+++ b/ycmd/tests/typescript/subcommands_test.py
@@ -660,7 +660,7 @@ def Subcommands_FixIt_test( app ):
               ChunkMatcher(
                 matches_regexp(
                   '^\r?\n'
-                  '    nonExistingMethod\\(\\): any {\r?\n'
+                  '    nonExistingMethod\\(\\) {\r?\n'
                   '        throw new Error\\("Method not implemented."\\);\r?\n'
                   '    }$',
                 ),

[codecov]

Codecov Report

Merging #1261 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1261   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files          95       95           
  Lines        7294     7294           
  Branches      153      153           
=======================================
  Hits         7104     7104           
  Misses        149      149           
  Partials       41       41

[pabra]

Thanks for this great project and keep up the good work.

[bstaletic]

Can you squash the commits, please? I should have mentioned that before.

Also, after you squash commits you should prepend [READY] to the PR title.

[bstaletic]

Thanks for the PR.

Reviewed 2 of 2 files at r1.
Reviewable status: 1 of 2 LGTMs obtained

[puremourning]

Reviewed 2 of 2 files at r1.
Reviewable status: complete! 2 of 2 LGTMs obtained

[mergify]

Thanks for sending a PR!

[mergify]

Thanks for sending a PR!

[mergify]

Thanks for sending a PR!