[READY] Remap GoTo commands in Python completer #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map GoTo, GoToDefinition, and GoToDeclaration to Jedi goto_assignments. Add GoToType command and map it to Jedi goto_definitions.
|
Tried this out on ycmd codebase and it works great. Thanks @micbou ! |
bstaletic
approved these changes
Jun 26, 2019
There was a problem hiding this comment.
Okay, despite the Jedi API being really confusing regarding these things, 
Reviewed 12 of 12 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
puremourning
commented
Jun 26, 2019
There was a problem hiding this comment.
Reviewed 12 of 12 files at r1.
Reviewable status:complete! 2 of 2 LGTMs obtained
|
Thanks for sending a PR! |
1 similar comment
|
Thanks for sending a PR! |
Codecov Report
@@ Coverage Diff @@
## master #1275 +/- ##
==========================================
+ Coverage 97.19% 97.22% +0.03%
==========================================
Files 96 96
Lines 7414 7433 +19
Branches 153 153
==========================================
+ Hits 7206 7227 +21
+ Misses 167 165 -2
Partials 41 41 |
|
Thanks for sending a PR! |
bstaletic
pushed a commit
to bstaletic/YouCompleteMe
that referenced
this pull request
Jul 3, 2019
ycm-core/ycmd#1275 Remap python GoTo* commands ycm-core/ycmd#1274 Migrate to Omnisharp-Roslyn ycm-core/ycmd#1239 Error ID in diagnostic messages ycm-core/ycmd#1267 Clangd extra conf support ycm-core/ycmd#1266 JDT update to 0.40.0 ycm-core/ycmd#1245 Generic (pluggable) LSP completer support ycm-core/ycmd#1263 Support JDT extensions ycm-core/ycmd#1261 Typescript update ycm-core/ycmd#1264 [vimspector](/puremourning/vimspector) configuration ycm-core/ycmd#1262 Multi-user installation ycm-core/ycmd#1243 Migrate to GOPLS ycm-core/ycmd#1249 Support MSVC 16 (VS2019) ycm-core/ycmd#1224 Migrate to RLS
bstaletic
pushed a commit
to bstaletic/YouCompleteMe
that referenced
this pull request
Jul 4, 2019
ycm-core/ycmd#1275 Remap python GoTo* commands ycm-core/ycmd#1274 Migrate to Omnisharp-Roslyn ycm-core/ycmd#1239 Error ID in diagnostic messages ycm-core/ycmd#1267 Clangd extra conf support ycm-core/ycmd#1266 JDT update to 0.40.0 ycm-core/ycmd#1245 Generic (pluggable) LSP completer support ycm-core/ycmd#1263 Support JDT extensions ycm-core/ycmd#1261 Typescript update ycm-core/ycmd#1264 [vimspector](/puremourning/vimspector) configuration ycm-core/ycmd#1262 Multi-user installation ycm-core/ycmd#1243 Migrate to GOPLS ycm-core/ycmd#1249 Support MSVC 16 (VS2019) ycm-core/ycmd#1224 Migrate to RLS
4 tasks
bstaletic
pushed a commit
to bstaletic/YouCompleteMe
that referenced
this pull request
Jul 4, 2019
ycm-core/ycmd#1275 Remap python GoTo* commands ycm-core/ycmd#1274 Migrate to Omnisharp-Roslyn ycm-core/ycmd#1239 Error ID in diagnostic messages ycm-core/ycmd#1267 Clangd extra conf support ycm-core/ycmd#1266 JDT update to 0.40.0 ycm-core/ycmd#1245 Generic (pluggable) LSP completer support ycm-core/ycmd#1263 Support JDT extensions ycm-core/ycmd#1261 Typescript update ycm-core/ycmd#1264 [vimspector](/puremourning/vimspector) configuration ycm-core/ycmd#1262 Multi-user installation ycm-core/ycmd#1243 Migrate to GOPLS ycm-core/ycmd#1249 Support MSVC 16 (VS2019) ycm-core/ycmd#1224 Migrate to RLS
bstaletic
pushed a commit
to bstaletic/YouCompleteMe
that referenced
this pull request
Jul 4, 2019
ycm-core/ycmd#1275 Remap python GoTo* commands ycm-core/ycmd#1274 Migrate to Omnisharp-Roslyn ycm-core/ycmd#1239 Error ID in diagnostic messages ycm-core/ycmd#1267 Clangd extra conf support ycm-core/ycmd#1266 JDT update to 0.40.0 ycm-core/ycmd#1245 Generic (pluggable) LSP completer support ycm-core/ycmd#1263 Support JDT extensions ycm-core/ycmd#1261 Typescript update ycm-core/ycmd#1264 [vimspector](/puremourning/vimspector) configuration ycm-core/ycmd#1262 Multi-user installation ycm-core/ycmd#1243 Migrate to GOPLS ycm-core/ycmd#1249 Support MSVC 16 (VS2019) ycm-core/ycmd#1224 Migrate to RLS
bstaletic
pushed a commit
to bstaletic/YouCompleteMe
that referenced
this pull request
Jul 5, 2019
ycm-core/ycmd#1275 Remap python GoTo* commands ycm-core/ycmd#1274 Migrate to Omnisharp-Roslyn ycm-core/ycmd#1239 Error ID in diagnostic messages ycm-core/ycmd#1267 Clangd extra conf support ycm-core/ycmd#1266 JDT update to 0.40.0 ycm-core/ycmd#1245 Generic (pluggable) LSP completer support ycm-core/ycmd#1263 Support JDT extensions ycm-core/ycmd#1261 Typescript update ycm-core/ycmd#1264 [vimspector](/puremourning/vimspector) configuration ycm-core/ycmd#1262 Multi-user installation ycm-core/ycmd#1243 Migrate to GOPLS ycm-core/ycmd#1249 Support MSVC 16 (VS2019) ycm-core/ycmd#1224 Migrate to RLS
bstaletic
pushed a commit
to bstaletic/ycmd
that referenced
this pull request
Oct 19, 2019
PR ycm-core#1275 broke GoTo in python in more ways than one. See: - ycm-core/YouCompleteMe#3458 - ycm-core#1341 Changes in the behaviour: - GoTo, GoToDefinition and GoToDeclaration now do what GoToType used to do. - We don't expose jedi's `goto_assignments` which can be useful, but we do have GoToReferences that calls jedi's `usages()`. - This means that `GoTo` on `self.x` will now jump to the definition of the type of `x`, while `GoToReferences` will do what is expected. - The `goto_usages` for this case returns "weird" locations, see ycm-core#1341 for details.
Merged
bstaletic
pushed a commit
to bstaletic/ycmd
that referenced
this pull request
Oct 19, 2019
PR ycm-core#1275 broke GoTo in python in more ways than one. See: - ycm-core/YouCompleteMe#3458 - ycm-core#1341 Changes in the behaviour: - GoTo, GoToDefinition and GoToDeclaration now do what GoToType used to do. - We don't expose jedi's `goto_assignments` which can be useful, but we do have GoToReferences that calls jedi's `usages()`. - This means that `GoTo` on `self.x` will now jump to the definition of the type of `x`, while `GoToReferences` will do what is expected. - The `goto_usages` for this case returns "weird" locations, see ycm-core#1341 for details.
ObiWahn
pushed a commit
to ObiWahn/ycmd
that referenced
this pull request
Dec 2, 2019
PR ycm-core#1275 broke GoTo in python in more ways than one. See: - ycm-core/YouCompleteMe#3458 - ycm-core#1341 Changes in the behaviour: - GoTo, GoToDefinition and GoToDeclaration now do what GoToType used to do. - We don't expose jedi's `goto_assignments` which can be useful, but we do have GoToReferences that calls jedi's `usages()`. - This means that `GoTo` on `self.x` will now jump to the definition of the type of `x`, while `GoToReferences` will do what is expected. - The `goto_usages` for this case returns "weird" locations, see ycm-core#1341 for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map GoTo, GoToDefinition, and GoToDeclaration to Jedi goto_assignments.
Add GoToType command and map it to Jedi goto_definitions.
Rebases #1200 on master.
This change is