Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect.lindep.data.frame() does not pass on the suppressPrint parameter #11

Closed
joachim-gassen opened this issue Aug 31, 2021 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@joachim-gassen
Copy link

Hi there:

If I am not mistaken, detect.lindep.data.frame() does not pass on the suppressPrint parameter to detect.lindep.matrix(). At least for me, this causes the parameter to have no effect when calling detect.lindep() with a dataframe as first argument and suppressPrint = TRUE. The same seems to be the case for detect.lindep.plm() (untested).

II am talking about lines 205 and 215 of detect_lin_dep_alias.R. Please feel free to correct me if I am off.

Thanks for maintaining this great package!

Joachim

@tappek tappek added the bug Something isn't working label Aug 31, 2021
@tappek tappek added this to the plm 2.4-2 milestone Aug 31, 2021
@tappek
Copy link
Collaborator

tappek commented Aug 31, 2021

Thank you for reporting and the kind words about our package! Good catch and very precise report.

I have just fixed this in our development repository rev. 1298, https://r-forge.r-project.org/R/?group_id=406.
Woudl you mind giving it try? install.packages("plm", repos="http://R-Forge.R-project.org")

In other news you might want to try the fast mode (enable options("plm.fast" = TRUE).

Btw, in case you have not seen it: The help page for detect.lindep has an example for within transformation which could fit in your domain (CEOage/tenure simultaneously in FE regression - similar to a pitfall I once ran into as I was not thinking and, hence, created detect.lindep).

@tappek tappek closed this as completed Aug 31, 2021
@tappek
Copy link
Collaborator

tappek commented Sep 21, 2021

plm version 2.4-2 is now CRAN (2021-09-21) containing this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants