Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: package imports in example scripts #38

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Conversation

crownpku
Copy link
Contributor

@crownpku crownpku commented Feb 8, 2021

fix package imports in example scripts

@portellaa
Copy link
Member

Hi @crownpku , thanks for your contribution.

Please fix the name of the pull request and be careful with the commit message, it should be fix: package imports in example scripts (please note the : after the fix keyword)

We use conventional commit messages for semantic releasing, you can learn more here 👉 https://www.conventionalcommits.org/en/v1.0.0/

@crownpku crownpku changed the title fix package imports in example scripts fix: package imports in example scripts Feb 9, 2021
@crownpku
Copy link
Contributor Author

crownpku commented Feb 9, 2021

Let me know if it works now (or you can squash and merge and set the commit message only once?)

@fabclmnt
Copy link
Contributor

fabclmnt commented Feb 9, 2021

@crownpku it works! Thank you for you contribution.

@fabclmnt fabclmnt linked an issue Feb 9, 2021 that may be closed by this pull request
@fabclmnt fabclmnt merged commit ca810b2 into ydataai:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Examples imports of YData lib are not up to date.
3 participants