org.cactoos.io.Joined: add a Ctor of Iterable<Input>

[ilyakharlamov]

org.cactoos.io.Joined in a constructor uses new ...

private final Iterable<Input> inputs;

public Joined(final Input first, final Input... rest) {
    this.inputs = new org.cactoos.iterable.Joined<>(
        first,
        new IterableOf<>(rest)
    );
}
// there are no other constructors

This is valid but calling new in a Ctor have a sign of a code smell.
I suggest adding a constructor that only takes Iterable<Input>

[0crat]

@llorllale/z please, pay attention to this issue

[llorllale]

@ilyakharlamov

calling new in a Ctor have a sign of a code smell.

I disagree. What makes you think this? We do this constantly in secondary constructors. You can think of them as "adapter constructors".

I suggest adding a constructor that only takes Iterable

If that's something you need, we can surely implement it.

[ilyakharlamov]

@llorllale There is more than one way to look at this.
For example

class A {
  private final List<String> list;
  A() {
     this.list = new ArrayList<String>;
  }
}

Using new in a constructor, relying on a concrete implementation rather than interface violates the D in SOLID principles.
Some people find it appropriate, some are not. At some point somewhere, new has to be called. Just need to be very careful about calling new inside a class that a lot of other classes depend on.

[llorllale]

@ilyakharlamov the implementation of the class itself can depend just on the highest abstraction, while having secondary ctors for usability ("user experience")

[victornoel]

@llorllale can we get a new release of cactoos? The work done for this issue is needed in yegor256/cactoos-http#69

[llorllale]

@rultor release, tag is 0.39

[rultor]

@rultor release, tag is 0.39

@llorllale OK, I will release it now. Please check the progress here

[rultor]

@rultor release, tag is 0.39

@llorllale Done! FYI, the full log is here (took me 14min)

[victornoel]

@llorllale thx

[llorllale]

@ilyakharlamov this was done by you in PR #1038

[0crat]

Job gh:yegor256/cactoos#1035 is not assigned, can't get performer

[0crat]

This job is not in scope