(#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1038

ilyakharlamov · 2019-01-22T03:34:03Z

This PR:
Regarding #1035
creates a constructor and adds a unit test for that

0crat · 2019-01-22T03:40:58Z

Job #1038 is now in scope, role is REV

…(period)

codecov-io · 2019-01-22T03:50:59Z

Codecov Report

Merging #1038 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1038      +/-   ##
============================================
+ Coverage     87.46%   87.47%   +<.01%     
- Complexity     1514     1515       +1     
============================================
  Files           266      266              
  Lines          3885     3887       +2     
  Branches        212      212              
============================================
+ Hits           3398     3400       +2     
  Misses          438      438              
  Partials         49       49

Impacted Files	Coverage Δ	Complexity Δ
src/main/java/org/cactoos/io/Joined.java	`100% <100%> (ø)`	`5 <2> (+1)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8bf44e...5feae8c. Read the comment docs.

0crat · 2019-01-22T03:51:23Z

This pull request #1038 is assigned to @fabriciofx /z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale /z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

fabriciofx

@ilyakharlamov Done. Please, check out.

src/main/java/org/cactoos/io/Joined.java

fabriciofx · 2019-01-22T10:41:14Z

src/main/java/org/cactoos/io/Joined.java

+    public Joined(final Iterable<Input> inputs) {
+        this.inputs = inputs;
+    }
+
    /**
     * Ctor.
     * @param first First input
     * @param rest The rest
     */
    public Joined(final Input first, final Input... rest) {


@ilyakharlamov Same above.

fabriciofx · 2019-01-22T10:41:16Z

src/main/java/org/cactoos/io/Joined.java

+        this(
+            new org.cactoos.iterable.Joined<>(
+                first,
+                new IterableOf<>(rest)


@ilyakharlamov Same above.

src/test/java/org/cactoos/io/JoinedTest.java

…(tests formatting)

…(Input of bytes test)

fabriciofx

@ilyakharlamov Done. Please, check it again.

src/test/java/org/cactoos/io/JoinedTest.java

…(Input of bytes test)

src/main/java/org/cactoos/io/Joined.java

…(Ctor arg rename)

fabriciofx · 2019-01-25T00:30:51Z

@ilyakharlamov This PR seems fine to me. Congratulations! It was a great job!

fabriciofx · 2019-01-25T00:30:58Z

@rultor merge

rultor · 2019-01-25T00:32:14Z

@rultor merge

@fabriciofx Thanks for your request. @llorllale Please confirm this.

src/test/java/org/cactoos/io/JoinedTest.java

llorllale · 2019-01-25T00:38:44Z

@ilyakharlamov left you some comments

…(test cleanup)

fabriciofx · 2019-01-25T04:28:28Z

@ilyakharlamov This PR seems fine to me. Great job!

fabriciofx · 2019-01-25T04:28:36Z

@rultor merge

rultor · 2019-01-25T04:29:01Z

@rultor merge

@fabriciofx Thanks for your request. @llorllale Please confirm this.

llorllale · 2019-01-26T12:45:25Z

@rultor merge

rultor · 2019-01-26T12:46:08Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-26T12:58:36Z

@rultor merge

@ilyakharlamov @llorllale Oops, I failed. You can see the full log here (spent 12min)

[INFO] artifact org.apache.maven.plugins:maven-source-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.plugins:maven-surefire-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.plugins:maven-resources-plugin: checking for updates from central
[INFO] artifact org.apache.maven.plugins:maven-release-plugin: checking for updates from central
[INFO] artifact org.apache.maven.plugins:maven-verifier-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.plugins:maven-site-plugin: checking for updates from central
[INFO] artifact org.apache.maven.plugins:maven-war-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.doxia:doxia-module-markdown: checking for updates from central
[INFO] artifact org.codehaus.mojo:versions-maven-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.plugins:maven-source-plugin: checking for updates from central
[INFO] artifact org.eluder.coveralls:coveralls-maven-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.plugins:maven-surefire-plugin: checking for updates from central
[INFO] artifact org.jacoco:jacoco-maven-plugin: checking for updates from oss.sonatype.org
[INFO] artifact org.apache.maven.plugins:maven-war-plugin: checking for updates from central
[INFO] artifact org.apache.maven.plugins:maven-verifier-plugin: checking for updates from central
[INFO] artifact org.codehaus.mojo:versions-maven-plugin: checking for updates from central
[INFO] artifact org.jacoco:jacoco-maven-plugin: checking for updates from central
[INFO] artifact org.eluder.coveralls:coveralls-maven-plugin: checking for updates from central
[INFO] Generating "JavaDocs" report             --- maven-javadoc-plugin:2.10.4:javadoc
[WARNING] Error fetching link: https://github.com/yegor256/takes/apidocs/package-list. Ignored it.
[WARNING] Error fetching link: https://github.com/llorllale/cactoos-matchers/apidocs/package-list. Ignored it.
[WARNING] Error fetching link: http://junit.org/apidocs/package-list. Ignored it.
[WARNING] Error fetching link: https://github.com/hamcrest/JavaHamcrest/hamcrest-core/apidocs/package-list. Ignored it.
[WARNING] Error fetching link: https://github.com/hamcrest/JavaHamcrest/hamcrest-library/apidocs/package-list. Ignored it.
[WARNING] Error fetching link: https://github.com/mockito/mockito/apidocs/package-list. Ignored it.
[INFO] 
4 warnings
[WARNING] Javadoc Warnings
[WARNING] javadoc: warning - Error fetching URL: http://docs.mockito.googlecode.com/hg/latest/
[WARNING] javadoc: warning - Error fetching URL: http://www.h2database.com/javadoc/
[WARNING] javadoc: warning - Error fetching URL: http://jolbox.com/bonecp/downloads/site/apidocs/
[WARNING] /home/r/repo/src/main/java/org/cactoos/time/package-info.java:34: warning - Tag @link: reference not found: org.cactoos.time
[INFO] Generating "JaCoCo Aggregate" report     --- jacoco-maven-plugin:0.7.7.201606060606:report-aggregate
[INFO] Generating Sitemap.
[INFO] Rendering 1 generated Doxia document: 1 xdoc
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:20 min
[INFO] Finished at: 2019-01-26T12:57:09+00:00
[INFO] Final Memory: 49M/522M
[INFO] ------------------------------------------------------------------------
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
To git@github.com:yegor256/cactoos.git
 ! [rejected]        master -> master (fetch first)
error: failed to push some refs to 'git@github.com:yegor256/cactoos.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.
container 059f2df9e147aa167239e926d5d8fb7539c6b6c971b27619bb08b0294a8c90f4 is dead
Sat Jan 26 13:58:27 CET 2019

ilyakharlamov · 2019-01-26T16:27:48Z

not sure why it's failed, I see no merge conflicts

…tos-joined-ctor

fabriciofx · 2019-01-26T22:29:45Z

@llorllale Can you try merge it again?

llorllale · 2019-01-27T14:55:52Z

@rultor merge

rultor · 2019-01-27T14:56:58Z

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-27T15:10:16Z

@rultor merge

@llorllale Done! FYI, the full log is here (took me 13min)

0crat · 2019-01-27T16:09:28Z

The job #1038 is now out of scope

0crat · 2019-01-27T16:15:48Z

Order was finished: +15 point(s) just awarded to @fabriciofx /z

0crat · 2019-01-27T16:36:37Z

Job gh:yegor256/cactoos#1038 doesn't exist in WBS, can't create order

0crat · 2019-01-27T16:39:04Z

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @llorllale /z

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input>

9efec7f

0crat added the scope label Jan 22, 2019

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> …

50b77c6

…(period)

fabriciofx reviewed Jan 22, 2019

View reviewed changes

ilyakharlamov added 3 commits January 24, 2019 10:11

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> …

cc00c99

…(tests formatting)

Merge remote-tracking branch 'yegor256/master' into cactos-joined-ctor

960958e

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> …

8f4aa73

…(Input of bytes test)

fabriciofx reviewed Jan 24, 2019

View reviewed changes

src/test/java/org/cactoos/io/JoinedTest.java Outdated Show resolved Hide resolved

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> …

238f6b3

…(Input of bytes test)

fabriciofx reviewed Jan 25, 2019

View reviewed changes

src/main/java/org/cactoos/io/Joined.java Outdated Show resolved Hide resolved

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> …

1826c76

…(Ctor arg rename)

llorllale reviewed Jan 25, 2019

View reviewed changes

src/test/java/org/cactoos/io/JoinedTest.java Outdated Show resolved Hide resolved

llorllale reviewed Jan 25, 2019

View reviewed changes

src/test/java/org/cactoos/io/JoinedTest.java Outdated Show resolved Hide resolved

(yegor256#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> …

2dce54a

…(test cleanup)

Merge branch 'master' of https://github.com/yegor256/cactoos into cac…

5feae8c

…tos-joined-ctor

rultor merged commit 5feae8c into yegor256:master Jan 27, 2019

0crat removed the scope label Jan 27, 2019

ilyakharlamov deleted the cactos-joined-ctor branch January 27, 2019 16:45

victornoel mentioned this pull request Jan 28, 2019

(#42) HtHead can be broken. yegor256/cactoos-http#69

Merged

llorllale mentioned this pull request Mar 2, 2019

org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1035

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1038

(#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1038

ilyakharlamov commented Jan 22, 2019

0crat commented Jan 22, 2019

codecov-io commented Jan 22, 2019 •

edited

Loading

0crat commented Jan 22, 2019

fabriciofx left a comment

fabriciofx Jan 22, 2019

fabriciofx Jan 22, 2019

fabriciofx left a comment

fabriciofx commented Jan 25, 2019

fabriciofx commented Jan 25, 2019

rultor commented Jan 25, 2019

llorllale commented Jan 25, 2019

fabriciofx commented Jan 25, 2019

fabriciofx commented Jan 25, 2019

rultor commented Jan 25, 2019

llorllale commented Jan 26, 2019

rultor commented Jan 26, 2019

rultor commented Jan 26, 2019

ilyakharlamov commented Jan 26, 2019

fabriciofx commented Jan 26, 2019

llorllale commented Jan 27, 2019

rultor commented Jan 27, 2019

rultor commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

(#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1038

(#1035) org.cactoos.io.Joined: add a Ctor of Iterable<Input> #1038

Conversation

ilyakharlamov commented Jan 22, 2019

0crat commented Jan 22, 2019

codecov-io commented Jan 22, 2019 • edited Loading

Codecov Report

0crat commented Jan 22, 2019

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx Jan 22, 2019

Choose a reason for hiding this comment

fabriciofx Jan 22, 2019

Choose a reason for hiding this comment

fabriciofx left a comment

Choose a reason for hiding this comment

fabriciofx commented Jan 25, 2019

fabriciofx commented Jan 25, 2019

rultor commented Jan 25, 2019

llorllale commented Jan 25, 2019

fabriciofx commented Jan 25, 2019

fabriciofx commented Jan 25, 2019

rultor commented Jan 25, 2019

llorllale commented Jan 26, 2019

rultor commented Jan 26, 2019

rultor commented Jan 26, 2019

ilyakharlamov commented Jan 26, 2019

fabriciofx commented Jan 26, 2019

llorllale commented Jan 27, 2019

rultor commented Jan 27, 2019

rultor commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

0crat commented Jan 27, 2019

codecov-io commented Jan 22, 2019 •

edited

Loading