-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#1573) Generify org.cactoos.experimental
package.
#1627
(#1573) Generify org.cactoos.experimental
package.
#1627
Conversation
Threads
ctor.Experimental
package.
Experimental
package. org.cactoos.Experimental
package.
org.cactoos.Experimental
package. org.cactoos.experimental
package.
@0crat status |
@0crat, status |
@0crat status |
Codecov Report
@@ Coverage Diff @@
## master #1627 +/- ##
============================================
- Coverage 90.12% 90.10% -0.02%
- Complexity 1602 1603 +1
============================================
Files 298 298
Lines 3745 3749 +4
Branches 122 122
============================================
+ Hits 3375 3378 +3
Misses 337 337
- Partials 33 34 +1
Continue to review full report at Codecov.
|
@victornoel, how can I fix that failed code coverage check? |
@rocket-3 no need to, it's more of a glitch than an actual problem, minus 0.02% is the same as no changes. I never found how to prevent this unfortunately... |
@0crat status |
@0crat in |
@0crat status |
@@ -188,7 +188,7 @@ public Threads( | |||
* @param tasks The tasks to be executed concurrently. | |||
*/ | |||
private Threads( | |||
final Func<Iterable<Callable<T>>, Iterable<Future<T>>> fnc, | |||
final Func<? super Iterable<Callable<T>>, ? extends Iterable<? extends Future<T>>> fnc, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rocket-3 I think we are missing some in there, for the first Iterable
, the Callable
as well as the Future
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@victornoel OK, as I see, it's a private ctor., therefore, it should be remained intact, as I think.
So I changed the PR to just puzzle removal commit.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rocket-3 why not indeed
a14ab90
to
baa9d82
Compare
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 9min) |
For #1573.
org.cactoos.experimental.Threads
classtodo
commentActually one class and one constructor, which contract, in my opinion, could be
relaxed
.