Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate LengthOf classes #910

Closed
neonailol opened this issue Jun 14, 2018 · 18 comments
Closed

Consolidate LengthOf classes #910

neonailol opened this issue Jun 14, 2018 · 18 comments
Labels
Milestone

Comments

@neonailol
Copy link
Contributor

As the title says, why there are multiple LengthOf classes when one of the points of elegant objects is to provide rich constructors for the object? Each current implementation of LengthOf can be merged into a single class, and I don't see why it should not be that way.

@0crat
Copy link
Collaborator

0crat commented Jun 14, 2018

@llorllale/z please, pay attention to this issue

@0crat
Copy link
Collaborator

0crat commented Jun 14, 2018

@neonailol/z this project will fix the problem faster if you donate a few dollars to it; just click here and pay via Stripe, it's very fast, convenient and appreciated; thanks a lot!

@llorllale
Copy link
Contributor

@neonailol where would we put this LengthOf?

@neonailol
Copy link
Contributor Author

@llorllale all of the implementations are NumberEnvelope so probably it belongs to scalar, but I think numbers should be in their own package

@llorllale
Copy link
Contributor

@neonailol agreed

@llorllale
Copy link
Contributor

@0crat in

@0crat 0crat added the scope label Jun 15, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 15, 2018

@0crat in (here)

@llorllale Job #910 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jun 15, 2018

Bug was reported, see §29: +15 point(s) just awarded to @neonailol/z

@llorllale llorllale added the bug label Jun 19, 2018
@llorllale
Copy link
Contributor

@neonailol FYI, when I agreed here I meant it probably should belong to org.cactoos.scalar, not to create a new package for numbers.

@llorllale llorllale changed the title Why there are multiple LengthOf classes? Consolidate LengthOf classes Jul 2, 2018
@llorllale llorllale added this to the 1.0.0 milestone Jul 2, 2018
@neonailol
Copy link
Contributor Author

@llorllale I am ok with that

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

The job #910 assigned to @dgroup/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

dgroup added a commit to dgroup/cactoos that referenced this issue Jan 3, 2019
@dgroup
Copy link
Contributor

dgroup commented Jan 3, 2019

@0crat wait as #987 raised.

@0crat
Copy link
Collaborator

0crat commented Jan 3, 2019

@0crat wait as #987 raised. (here)

@dgroup The impediment for #910 was registered successfully by @dgroup/z

dgroup added a commit to dgroup/cactoos that referenced this issue Jan 3, 2019
@dgroup
Copy link
Contributor

dgroup commented Jan 3, 2019

@neonailol, the PR was merged.
Could you please check the results?
Can we close the ticket?

@neonailol
Copy link
Contributor Author

@dgroup yes, this issue can be closed

@dgroup
Copy link
Contributor

dgroup commented Jan 11, 2019

@llorllale please close the ticket as requestor approved the fix.

@0crat 0crat removed the scope label Jan 11, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 11, 2019

The job #910 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 11, 2019

Order was finished: +30 point(s) just awarded to @dgroup/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants