Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

method equals() in CollectionEnvelope should be extended #917

Closed
butenkos opened this issue Jul 2, 2018 · 18 comments
Closed

method equals() in CollectionEnvelope should be extended #917

butenkos opened this issue Jul 2, 2018 · 18 comments
Labels

Comments

@butenkos
Copy link

butenkos commented Jul 2, 2018

method public boolean equals(Object obj) of CollectionEnvelope should be extended - it should return true when this == obj, otherwise it's performing a redundant comparison of all the elements of two collections even though both collections are the same object

@0crat
Copy link
Collaborator

0crat commented Jul 2, 2018

@llorllale/z please, pay attention to this issue

@llorllale llorllale added the bug label Jul 3, 2018
@llorllale
Copy link
Contributor

@0crat in

@0crat 0crat added the scope label Jul 3, 2018
@0crat
Copy link
Collaborator

0crat commented Jul 3, 2018

Job #917 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Jul 3, 2018

@0crat in (here)

@llorllale Job #917 is already in scope

@0crat
Copy link
Collaborator

0crat commented Jul 3, 2018

Bug was reported, see §29: +15 point(s) just awarded to @butenkos/z

@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

The job #917 assigned to @sereshqua/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@llorllale
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Mar 18, 2019

@0crat refuse (here)

@llorllale The user @sereshqua/z resigned from #917, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Mar 27, 2019

The job #917 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator

@0crat wait for #1087 to be merged

@victornoel
Copy link
Collaborator

@butenkos can you confirm this is what you had in mind?

@0crat 0crat added the waiting label Mar 29, 2019
@0crat
Copy link
Collaborator

0crat commented Mar 29, 2019

@0crat wait for #1087 to be merged (here)

@victornoel The impediment for #917 was registered successfully by @victornoel/z

victornoel added a commit to victornoel/cactoos that referenced this issue Mar 30, 2019
victornoel added a commit to victornoel/cactoos that referenced this issue Mar 30, 2019
@victornoel
Copy link
Collaborator

@butenkos this was merged, can you close the issue?

@butenkos butenkos closed this as completed Apr 4, 2019
@0crat 0crat removed the waiting label Apr 4, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 4, 2019

@sereshqua/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Apr 4, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 4, 2019

The job #917 is now out of scope

@sereshqua
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Apr 4, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Apr 4, 2019

Quality review completed: +4 point(s) just awarded to @sereshqua/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants