New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(#917) Improve performances of CollectionEnvelope equals #1087
(#917) Improve performances of CollectionEnvelope equals #1087
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1087 +/- ##
============================================
+ Coverage 87.41% 87.42% +<.01%
- Complexity 1543 1545 +2
============================================
Files 272 272
Lines 3974 3975 +1
Branches 219 219
============================================
+ Hits 3474 3475 +1
Misses 450 450
Partials 50 50
Continue to review full report at Codecov.
|
Job #1087 is now in scope, role is |
This pull request #1087 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@llorllale this PR is so small that I think you can directly review it, I don't think it is a good idea that I do it ;) (well, I believe it's good to merge :). |
@0crat refuse |
src/test/java/org/cactoos/collection/CollectionEnvelopeTest.java
Outdated
Show resolved
Hide resolved
@llorllale The user @victornoel/z resigned from #1087, please stop working. Reason for job resignation: Order was cancelled |
@victornoel 1 comment |
82bf397
to
7f96aaa
Compare
@llorllale oups, good point, I've updated the PR |
85f04f5
to
7f96aaa
Compare
This pull request #1087 is assigned to @atapin/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@llorllale ping |
@0crat refuse |
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 12min) |
Job |
The job #1087 is now out of scope |
This is for #917, there is not much in it, I also added a test which, even if not really needed in relation to the change, is not useless :)