Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#917) Improve performances of CollectionEnvelope equals #1087

Merged
merged 1 commit into from Apr 2, 2019

Conversation

victornoel
Copy link
Collaborator

This is for #917, there is not much in it, I also added a test which, even if not really needed in relation to the change, is not useless :)

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #1087 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1087      +/-   ##
============================================
+ Coverage     87.41%   87.42%   +<.01%     
- Complexity     1543     1545       +2     
============================================
  Files           272      272              
  Lines          3974     3975       +1     
  Branches        219      219              
============================================
+ Hits           3474     3475       +1     
  Misses          450      450              
  Partials         50       50
Impacted Files Coverage Δ Complexity Δ
...ava/org/cactoos/collection/CollectionEnvelope.java 100% <100%> (ø) 28 <9> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1cbb2...7f96aaa. Read the comment docs.

@0crat 0crat added the scope label Mar 29, 2019
@0crat
Copy link
Collaborator

0crat commented Mar 29, 2019

Job #1087 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Mar 29, 2019

This pull request #1087 is assigned to @victornoel/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator Author

@llorllale this PR is so small that I think you can directly review it, I don't think it is a good idea that I do it ;) (well, I believe it's good to merge :).

@llorllale
Copy link
Contributor

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Mar 30, 2019

@0crat refuse (here)

@llorllale The user @victornoel/z resigned from #1087, please stop working. Reason for job resignation: Order was cancelled

@llorllale
Copy link
Contributor

@victornoel 1 comment

@victornoel victornoel force-pushed the 917-collection-envelope-equals branch from 82bf397 to 7f96aaa Compare March 30, 2019 17:36
@victornoel
Copy link
Collaborator Author

@llorllale oups, good point, I've updated the PR

@victornoel victornoel force-pushed the 917-collection-envelope-equals branch from 85f04f5 to 7f96aaa Compare March 30, 2019 18:13
@0crat
Copy link
Collaborator

0crat commented Apr 1, 2019

This pull request #1087 is assigned to @atapin/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @llorllale/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@victornoel
Copy link
Collaborator Author

@llorllale ping

@llorllale
Copy link
Contributor

@0crat refuse

@llorllale
Copy link
Contributor

@rultor merge

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2019

@0crat refuse (here)

@llorllale The user @atapin/z resigned from #1087, please stop working. Reason for job resignation: Order was cancelled

@rultor
Copy link
Collaborator

rultor commented Apr 2, 2019

@rultor merge

@llorllale OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7f96aaa into yegor256:master Apr 2, 2019
@rultor
Copy link
Collaborator

rultor commented Apr 2, 2019

@rultor merge

@llorllale Done! FYI, the full log is here (took me 12min)

@0crat
Copy link
Collaborator

0crat commented Apr 2, 2019

Job gh:yegor256/cactoos#1087 is not assigned, can't get performer

@0crat 0crat removed the scope label Apr 2, 2019
@0crat
Copy link
Collaborator

0crat commented Apr 2, 2019

The job #1087 is now out of scope

@victornoel victornoel deleted the 917-collection-envelope-equals branch April 2, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants