Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization locks as constructor arguments #323

Merged
merged 2 commits into from
Jul 21, 2017
Merged

Synchronization locks as constructor arguments #323

merged 2 commits into from
Jul 21, 2017

Conversation

g4s8
Copy link
Contributor

@g4s8 g4s8 commented Jul 18, 2017

We need to be able to use custom lock for synchronization, not always Proc/Func/Scalar as lock.

@codecov-io
Copy link

codecov-io commented Jul 18, 2017

Codecov Report

Merging #323 into master will decrease coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #323      +/-   ##
============================================
- Coverage     74.22%   73.91%   -0.32%     
  Complexity      424      424              
============================================
  Files           131      131              
  Lines          1424     1430       +6     
  Branches         68       68              
============================================
  Hits           1057     1057              
- Misses          347      353       +6     
  Partials         20       20
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/func/SyncFunc.java 0% <0%> (ø) 0 <0> (ø) ⬇️
src/main/java/org/cactoos/func/SyncScalar.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d46fb6f...2956d32. Read the comment docs.

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 21, 2017

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2956d32 into yegor256:master Jul 21, 2017
@rultor
Copy link
Collaborator

rultor commented Jul 21, 2017

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 9min)

@g4s8 g4s8 deleted the sync-lock branch July 21, 2017 06:33
@yegor256
Copy link
Owner

@rultor release, tag is 0.11.8

@rultor
Copy link
Collaborator

rultor commented Jul 23, 2017

@rultor release, tag is 0.11.8

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Jul 23, 2017

@rultor release, tag is 0.11.8

@yegor256 Done! FYI, the full log is here (took me 9min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants