AsyncFunc: executor service as a field #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
============================================
+ Coverage 74.22% 74.41% +0.18%
- Complexity 424 431 +7
============================================
Files 131 132 +1
Lines 1424 1450 +26
Branches 68 69 +1
============================================
+ Hits 1057 1079 +22
- Misses 347 351 +4
Partials 20 20
Continue to review full report at Codecov.
|
yegor256
reviewed
Jul 20, 2017
| @@ -91,12 +92,12 @@ public AsyncFunc(final Proc<X> proc, final ThreadFactory fct) { | |||
| */ | |||
| public AsyncFunc(final Func<X, Y> fnc, final ThreadFactory fct) { | |||
| this.func = fnc; | |||
| this.factory = fct; | |||
| this.executor = Executors.newSingleThreadExecutor(fct); | |||
There was a problem hiding this comment.
@caarlos0 I believe that this ctor must become a secondary one. We should introduce a primary one, which will accept Func and ExecutorService.
|
@caarlos0 thanks, see my comment above |
|
@yegor256 pushed |
caarlos0
changed the title
|
this also close #324 |
|
@rultor merge |
|
@yegor256 can you deploy it please? |
|
@caarlos0 see 0.11.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may avoid the premature termination of the executor service...