Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jhome.java:82-85: The javac binary might not be available... #10

Closed
0pdd opened this issue Nov 22, 2023 · 6 comments · Fixed by #15
Closed

Jhome.java:82-85: The javac binary might not be available... #10

0pdd opened this issue Nov 22, 2023 · 6 comments · Fixed by #15
Assignees
Labels
bug Something isn't working

Comments

@0pdd
Copy link

0pdd commented Nov 22, 2023

The puzzle 5-ee2a7bdc from #5 has to be resolved:

* @todo #5 The javac binary might not be available in JRE.
* We should check if we are running in JDK or JRE and somehow decide what to
* return in this case or even throw an exception in case of JRE. Maybe an
* {@code Optional<Path>} is also a solution here.

The puzzle was created by @volodya-lombrozo on 22-Nov-23.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@volodya-lombrozo
Copy link
Contributor

@yegor256 Maybe we should just thrown an exception, if javac is absent on the current system. What do you think?

@volodya-lombrozo
Copy link
Contributor

btw, I can solve this issue

@yegor256
Copy link
Owner

@volodya-lombrozo yes, throwing an exception seems to be the right solution. Please, go ahead.

@yegor256 yegor256 added the bug Something isn't working label Nov 23, 2023
volodya-lombrozo added a commit to volodya-lombrozo/jhome that referenced this issue Nov 23, 2023
volodya-lombrozo added a commit to volodya-lombrozo/jhome that referenced this issue Nov 23, 2023
volodya-lombrozo added a commit to volodya-lombrozo/jhome that referenced this issue Nov 23, 2023
volodya-lombrozo added a commit to volodya-lombrozo/jhome that referenced this issue Nov 23, 2023
volodya-lombrozo added a commit to volodya-lombrozo/jhome that referenced this issue Nov 23, 2023
@yegor256
Copy link
Owner

@rultor release, tag is 0.0.4

@rultor
Copy link
Collaborator

rultor commented Nov 24, 2023

@rultor release, tag is 0.0.4

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Collaborator

rultor commented Nov 24, 2023

@rultor release, tag is 0.0.4

@yegor256 Done! FYI, the full log is here (took me 5min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants