Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String concatenation check sometimes doesn't work #502

Closed
krzyk opened this issue Nov 22, 2015 · 20 comments
Closed

String concatenation check sometimes doesn't work #502

krzyk opened this issue Nov 22, 2015 · 20 comments
Assignees
Labels

Comments

@krzyk
Copy link
Collaborator

krzyk commented Nov 22, 2015

In case of following code:

            throw new IllegalStateException("Failed to create checker"
                + " test" + ex.getMessage(), ex
            );

StringLiteralsConcatenationCheck will not report an error, but it should.

But it will report error in such case:

            throw new IllegalStateException("Failed to create checker"
                + " test" + " other", ex
            );

Waiting for fix in checkstyle/checkstyle#2766 (Actually it doesn't like like related to checkstyle/checkstyle#2766)
Please make this check work for both cases.

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 22, 2015

@davvd valid bug

@davvd
Copy link

davvd commented Nov 23, 2015

@davvd valid bug

@krzyk I just added bug tag here

@davvd
Copy link

davvd commented Nov 24, 2015

@krzyk many thanks, 30 mins added to your acc for reporting this bug, pmt ID 70521321

@krzyk
Copy link
Collaborator Author

krzyk commented Nov 24, 2015

@davvd this is postponed

@davvd
Copy link

davvd commented Nov 24, 2015

@davvd this is postponed

@krzyk right, I added "postponed" label

@davvd
Copy link

davvd commented Nov 24, 2015

@davvd this is postponed

@krzyk right, I'll try to find someone else for this task

@krzyk
Copy link
Collaborator Author

krzyk commented Dec 24, 2015

@Happy-Neko I'm wondering if this is a similar issue as #503, would like to pick it up?

@ikarsokolov
Copy link
Contributor

@krzyk Ok, I'll check it.

@ikarsokolov
Copy link
Contributor

@krzyk Same problem as #503.

@krzyk
Copy link
Collaborator Author

krzyk commented Dec 25, 2015

@Happy-Neko Thanks, I'll wait for the checkstyle fix before assigning this to you.

@yegor256 yegor256 mentioned this issue Jan 14, 2016
@krzyk
Copy link
Collaborator Author

krzyk commented Jan 26, 2016

@Happy-Neko I've look at this and it doesn't look like the same problem as in #503, can I assign you on this?

@ikarsokolov
Copy link
Contributor

@krzyk ok.

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 27, 2016

@davvd assign @Happy-Neko

@krzyk
Copy link
Collaborator Author

krzyk commented Jan 27, 2016

@davvd this is not postponed

@davvd
Copy link

davvd commented Jan 28, 2016

@davvd assign @Happy-Neko

@krzyk yep, done. @happy-neko it is your task now

@davvd
Copy link

davvd commented Jan 28, 2016

@davvd this is not postponed

@krzyk got it, "postponed" tag removed from here

@krzyk
Copy link
Collaborator Author

krzyk commented Feb 1, 2016

@Happy-Neko thanks

@krzyk krzyk closed this as completed Feb 1, 2016
@davvd
Copy link

davvd commented Feb 4, 2016

@happy-neko Many thanks! 30 mins were added to your account in Transaction ID AP-9NP06237JN410054F (task took 100 hours and 45 mins)... +30 added to your rating, current score is: +188

@krzyk
Copy link
Collaborator Author

krzyk commented Feb 28, 2016

@yegor256 I didn't get 30mins for reporting this issue, sorry, ignore this one my mistake

@yegor256
Copy link
Owner

@krzyk OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants