Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reproducer for #577 #947

Merged
merged 1 commit into from
Jan 20, 2019
Merged

Add reproducer for #577 #947

merged 1 commit into from
Jan 20, 2019

Conversation

Serranya
Copy link
Contributor

This adds a simplified testcase for the problem described in #577

A puzzle tracks the completion of the actual fix.

@0crat 0crat added the scope label Jan 16, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 16, 2019

Job #947 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2019

This pull request #947 is assigned to @fabriciofx/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@codecov-io
Copy link

codecov-io commented Jan 16, 2019 •
edited
Loading

Codecov Report

Merging #947 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #947   +/-   ##
========================================
  Coverage      74.1%   74.1%           
  Complexity      971     971           
========================================
  Files           222     222           
  Lines          4785    4785           
  Branches        361     361           
========================================
  Hits           3546    3546           
  Misses         1089    1089           
  Partials        150     150

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e161aee...5b0a0bf. Read the comment docs.

fabriciofx
fabriciofx reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@fabriciofx fabriciofx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serranya Done. Please, check it.

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
fabriciofx
fabriciofx reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@fabriciofx fabriciofx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serranya done. Check it.

src/test/java/org/takes/rq/multipart/ContentDispositionHeaderText.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/ContentLengthHeaderText.java Outdated Show resolved Hide resolved
@Serranya
Copy link
Contributor Author

@fabriciofx Please take another look.

fabriciofx
fabriciofx reviewed Jan 16, 2019
View reviewed changes
Copy link
Contributor

@fabriciofx fabriciofx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serranya done. Check it again. Thanks!

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Outdated Show resolved Hide resolved
@Serranya
Copy link
Contributor Author

@fabriciofx Please review once more

@fabriciofx
Copy link
Contributor

@Serranya I seems fine now. Thanks!

@fabriciofx
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 17, 2019

@rultor merge

@fabriciofx Thanks for your request. @paulodamaso Please confirm this.

paulodamaso
paulodamaso suggested changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@paulodamaso paulodamaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Serranya Just a comment, please take a look

src/test/java/org/takes/rq/multipart/RqMtFakeTest.java Show resolved Hide resolved
@Serranya
Copy link
Contributor Author

@paulodamaso @fabriciofx I updated the PR once more

@fabriciofx
Copy link
Contributor

@paulodamaso Can you check what is wrong with Shippable? I think there is something wrong with Ruby installation...

@fabriciofx
Copy link
Contributor

@Serranya it's ok to me. Thanks!

@fabriciofx
Copy link
Contributor

@rultor merge

@paulodamaso
Copy link
Contributor

@fabriciofx It seems that I've activated shippable for takes by mistake, let's ignore it

@fabriciofx
Copy link
Contributor

@fabriciofx It seems that I've activated shippable for takes by mistake, let's ignore it

@paulodamaso ok! You can merge it now.

@rultor
Copy link
Collaborator

rultor commented Jan 19, 2019

@rultor merge

@fabriciofx Thanks for your request. @paulodamaso Please confirm this.

@paulodamaso
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 19, 2019

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5b0a0bf into yegor256:master Jan 20, 2019
@rultor
Copy link
Collaborator

rultor commented Jan 20, 2019

@rultor merge

@paulodamaso Done! FYI, the full log is here (took me 18min)

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

@ypshenychka/z please review this job completed by @fabriciofx/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jan 20, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

The job #947 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

@ypshenychka
Copy link

@Serranya According to our QA Rules:

Messages in a job always start with a name of a user they are addressed to.

Please correct your messages here and here by indicating an addressee in the beginning.

@Serranya Serranya deleted the #577 branch January 20, 2019 10:15
@Serranya Serranya mentioned this pull request Jan 20, 2019
Closed
@Serranya
Copy link
Contributor Author

@ypshenychka I updated the messages.

@ypshenychka
Copy link

@Serranya thanks

@ypshenychka
Copy link

@0crat quality acceptable

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

@0crat quality acceptable (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Order was finished, quality is "acceptable": +15 point(s) just awarded to @fabriciofx/z

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriciofx fabriciofx fabriciofx left review comments

@paulodamaso paulodamaso paulodamaso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Serranya @0crat @codecov-io @fabriciofx @rultor @paulodamaso @ypshenychka