Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RqMultiPart.Fake fails on more then one part #577

Closed
jhyle opened this issue Feb 5, 2016 · 27 comments
Closed

RqMultiPart.Fake fails on more then one part #577

jhyle opened this issue Feb 5, 2016 · 27 comments
Labels

Comments

@jhyle
Copy link

jhyle commented Feb 5, 2016

Please see yegor256/netbout#979. The TkAttachTest::takeAttachementNameFromField constructs a RqMultiPart.Fake request with two form-data parts. It fails with the exception

org.takes.HttpException: [400] header "Content-Disposition" is mandatory
    at org.takes.rq.RqHeaders$Smart.single(RqHeaders.java:206)
    at org.takes.rq.RqMultipart$Base.asMap(RqMultipart.java:313)
    at org.takes.rq.RqMultipart$Base.buildRequests(RqMultipart.java:224)
    at org.takes.rq.RqMultipart$Base.<init>(RqMultipart.java:140)
    at org.takes.rq.RqMultipart$Fake.<init>(RqMultipart.java:413)
    at com.netbout.rest.bout.TkAttachTest.takettachementNameFromField(TkAttachTest.java:214)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
    at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
    at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
    at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
    at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
    at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
    at org.apache.maven.surefire.junitcore.pc.Scheduler$1.run(Scheduler.java:318)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)

As Content-Disposition is given for both parts I suspect that RqMultiPart.Fake does not handle this correctly.

@davvd
Copy link

davvd commented Feb 9, 2016

@yegor256 please do something about this issue

@dmzaytsev
Copy link
Contributor

@yegor256 please do something about this issue

@krzyk
Copy link
Contributor

krzyk commented Mar 6, 2016

@yegor256 could you validate if this is a real bug?

@yegor256
Copy link
Owner

yegor256 commented Mar 9, 2016

@jhyle can you please post a unit test here, to reproduce the bug?

@yegor256
Copy link
Owner

@jhyle is it still a problem or I can close the ticket?

@paulodamaso
Copy link
Contributor

@0crat in

@0crat 0crat added the scope label Nov 27, 2018
@0crat
Copy link
Collaborator

0crat commented Nov 27, 2018

Job #577 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Nov 27, 2018

@0crat in (here)

@paulodamaso Job #577 is already in scope

@0crat
Copy link
Collaborator

0crat commented Nov 27, 2018

Thanks for your contribution, @jhyle/z! If you would be a member of the project, you would now earn +15 reputation points, as explained in §29. You can join and apply to it, see §2.

@0crat
Copy link
Collaborator

0crat commented Nov 29, 2018

The job #577 assigned to @robsonataide/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

@robsonataide/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@0crat
Copy link
Collaborator

0crat commented Dec 9, 2018

The user @robsonataide/z resigned from #577, please stop working. Reason for job resignation: It is older than 10 days, see §8

@0crat
Copy link
Collaborator

0crat commented Dec 9, 2018

Resigned on delay, see §8: -30 point(s) just awarded to @robsonataide/z

@0crat
Copy link
Collaborator

0crat commented Jan 15, 2019

The job #577 assigned to @Serranya/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

Serranya pushed a commit to Serranya/takes that referenced this issue Jan 16, 2019
Serranya pushed a commit to Serranya/takes that referenced this issue Jan 16, 2019
Serranya pushed a commit to Serranya/takes that referenced this issue Jan 16, 2019
Serranya pushed a commit to Serranya/takes that referenced this issue Jan 16, 2019
Serranya pushed a commit to Serranya/takes that referenced this issue Jan 17, 2019
Serranya pushed a commit to Serranya/takes that referenced this issue Jan 19, 2019
@0pdd
Copy link
Collaborator

0pdd commented Jan 20, 2019

@jhyle the puzzle #950 is still not solved.

@Serranya
Copy link
Contributor

@jhyle I added an Test that repduces the issue in #947. Actually fixing the issue is tracked in #950. Please close this issue so that only #950 is open.

@Serranya
Copy link
Contributor

@0crat wait for an answer from @jhyle

@0crat
Copy link
Collaborator

0crat commented Jan 20, 2019

@0crat wait for an answer from @jhyle (here)

@Serranya The impediment for #577 was registered successfully by @Serranya/z

@Serranya
Copy link
Contributor

@paulodamaso Hi, @jhyle did not answer in the last 8 days. Can you please close the issue?

@paulodamaso
Copy link
Contributor

@Serranya Thanks!

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

@ypshenychka/z please review this job completed by @Serranya/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Jan 28, 2019
@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

The job #577 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

@0crat quality good (here)

@ypshenychka The project doesn't have enough funds, can't make a payment

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

Order was finished, quality is "good": +35 point(s) just awarded to @Serranya/z

@0crat
Copy link
Collaborator

0crat commented Jan 28, 2019

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

@0pdd
Copy link
Collaborator

0pdd commented Mar 21, 2021

@jhyle the puzzle #1095 is still not solved; solved: #950.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

10 participants