Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#342 Handle case where host already exists in load balancing group #384

Merged
merged 2 commits into from
Oct 22, 2014
Merged

#342 Handle case where host already exists in load balancing group #384

merged 2 commits into from
Oct 22, 2014

Conversation

carlosmiranda
Copy link
Contributor

No description provided.

@davvd
Copy link
Collaborator

davvd commented Oct 22, 2014

Thanks, someone will review your pull request soon

@davvd
Copy link
Collaborator

davvd commented Oct 22, 2014

@yegor256 please review this PR

@yegor256
Copy link
Owner

hm.. what about a test? how do you know this change actually works?

@carlosmiranda
Copy link
Contributor Author

I created one, in NginxTest.retainsExistingHostsConfiguration(). Do you think it's not sufficient?

@yegor256
Copy link
Owner

oops, my bad. I didn't see it

@yegor256
Copy link
Owner

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Oct 22, 2014

@rultor merge pls

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7d60d30 into yegor256:master Oct 22, 2014
@rultor
Copy link
Collaborator

rultor commented Oct 22, 2014

@rultor merge pls

@yegor256 Done! FYI, the full log is here (took me 10min)

@davvd
Copy link
Collaborator

davvd commented Oct 27, 2014

@yegor256 Many thanks! 16 mins were added to your account in Transaction ID 000-03979eab

@davvd
Copy link
Collaborator

davvd commented Oct 27, 2014

@rultor please deploy

@rultor
Copy link
Collaborator

rultor commented Oct 27, 2014

@rultor please deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Oct 27, 2014

@rultor please deploy

@davvd Done! FYI, the full log is here (took me 7min)

@carlosmiranda carlosmiranda deleted the 342_2 branch October 29, 2014 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@yegor256
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@carlosmiranda @davvd @yegor256 @rultor